Skip to content

fix: Undo for elbow arrows create incorrect routing #9046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 24, 2025
Merged

fix: Undo for elbow arrows create incorrect routing #9046

merged 5 commits into from
Jan 24, 2025

Conversation

@mtolmacs
Copy link
Collaborator

@mtolmacs mtolmacs commented Jan 24, 2025

No description provided.

@mtolmacs
Fix for undo bug
1c6629e 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs mtolmacs self-assigned this Jan 24, 2025
@vercel
Copy link

vercel bot commented Jan 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jan 24, 2025 7:16pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jan 24, 2025 7:16pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jan 24, 2025 7:16pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 7:16pm

@mtolmacs mtolmacs requested a review from dwelle January 24, 2025 17:50
@mtolmacs
Fix the other way around
f4c9d59 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Fix affected test
ad80cdf 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Remove debug
d09f9c6 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@github-actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.65% (🎯 60%) 68182 / 102296
🟢 Statements 66.65% (🎯 60%) 68182 / 102296
🟢 Functions 63.73% (🎯 63%) 1956 / 3069
🟢 Branches 79.29% (🎯 70%) 8158 / 10288
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/excalidraw/element/elbowArrow.ts 67.57% 78.08% 93.1% 67.57% 130-162, 178-216, 226-245, 266-434, 458, 460-461, 487, 489-506, 513, 515-532, 563, 568, 587-596, 602-611, 615-637, 641-660, 681-858, 933, 984-985, 1000-1002, 1004-1025, 1138, 1177, 1185-1189, 1196, 1201-1205, 1291-1292, 1295-1296, 1323-1325, 1373-1375, 1422, 1426-1427, 1462-1464, 1499-1500, 1507, 1514, 1516, 1521, 1530, 1537, 1546, 1551, 1558, 1560, 1575-1594, 1611-1615, 1617-1636, 1648-1652, 1757-1758, 1763-1764, 1786-1787, 1799-1800, 1812-1813, 1843-1844, 1851-1852, 1856-1857, 1918-1920, 1983-1985, 2001-2003
Generated in workflow #4177 for commit cfe38f5 by the Vitest Coverage Report Action

@mtolmacs
Avoid flaky FP issues and additional comment
cfe38f5 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
dwelle
dwelle approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mtolmacs mtolmacs merged commit 49f1276 into master Jan 24, 2025
10 checks passed
@mtolmacs mtolmacs deleted the fix/elbow-undo-binding branch January 24, 2025 19:18
@dwelle dwelle mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

@mtolmacs mtolmacs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtolmacs @dwelle