Skip to content

feat: Remove GA code from binding #9042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 74 commits into from
Feb 25, 2025
Merged

feat: Remove GA code from binding #9042

merged 74 commits into from
Feb 25, 2025

Conversation

@mtolmacs
Copy link
Collaborator

@mtolmacs mtolmacs commented Jan 23, 2025 •
edited
Loading

The goal of the PR is to remove the Geometric Algebra from the codebase. Rationale behind it is that very few potential contributors are familiar with GA compared to vector geometry. This will also bring additional math tooling updates as well.

One additional benefit this refactor brings is closer and more precise tracking of curvatures on rounded objects.

@vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Feb 25, 2025 9:48pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Feb 25, 2025 9:48pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Feb 25, 2025 9:48pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 9:48pm

@mtolmacs mtolmacs changed the title Remove GA code from binding feat: Remove GA code from binding Jan 23, 2025
@mtolmacs mtolmacs self-assigned this Jan 23, 2025
@github-actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.97% (🎯 60%) 69133 / 103224
🟢 Statements 66.97% (🎯 60%) 69133 / 103224
🟢 Functions 64.24% (🎯 63%) 1946 / 3029
🟢 Branches 79.86% (🎯 70%) 8351 / 10456
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
excalidraw-app/components/DebugCanvas.tsx 19.47% 40% 16.66% 19.47% 24-36, 39-58, 61-70, 73-99, 102-155, 158-166, 169-177, 181-187, 198-199, 201-202, 211-308, 317-342
packages/excalidraw/constants.ts 99.56% 66.66% 100% 99.56% 11-12
packages/excalidraw/visualdebug.ts 0% 0% 0% 0% 1-164
packages/excalidraw/actions/actionProperties.tsx 78.82% 80.6% 87.5% 78.82% 204-206, 245, 295, 444-446, 462-471, 695, 781-807, 819-846, 872-873, 875-876, 888, 904-906, 944-967, 995, 1009, 1011-1015, 1021-1023, 1066-1071, 1073-1078, 1080-1140, 1169-1170, 1222, 1260-1261, 1310, 1335-1336, 1343, 1346, 1482-1514, 1567-1701, 1713-1719, 1764-1765
packages/excalidraw/element/binding.ts 88.93% 89.03% 94.64% 88.93% 270, 288, 322, 333, 379-380, 579-581, 588-589, 592-593, 606-621, 653-654, 675-676, 743-744, 903, 940, 943-945, 948-981, 996-1001, 1011-1027, 1031-1053, 1057-1076, 1136-1142, 1158, 1160-1161, 1169-1174, 1213, 1400-1401, 1409-1410, 1415-1416, 1469-1470, 1495-1496, 1723-1734, 1759-1762, 1776-1779, 1810, 1815, 1818, 1970-1971, 2082-2083, 2115-2119, 2155-2190, 2193-2202
packages/excalidraw/element/collision.ts 85.76% 91.83% 88.88% 85.76% 171, 175, 242-283
packages/excalidraw/element/distance.ts 100% 100% 100% 100%
packages/excalidraw/element/elbowArrow.ts 70.36% 84.73% 93.1% 70.36% 130-162, 178-216, 226-245, 272-440, 464, 466-467, 493, 495-512, 519, 521-538, 569, 574, 593-602, 608-617, 621-643, 647-666, 687-864, 911-918, 1041, 1043-1044, 1073-1074, 1089-1092, 1094-1115, 1236, 1275, 1283-1287, 1294, 1299-1303, 1389-1390, 1393-1394, 1421-1423, 1471-1473, 1520, 1524-1525, 1560-1562, 1597-1598, 1673-1692, 1709-1713, 1725-1729, 1855-1856, 1897-1898, 1910-1911, 1941-1942, 1954-1955, 2057-2066, 2108-2110
packages/excalidraw/element/utils.ts 70.7% 71.42% 100% 70.7% 252-355
packages/math/angle.ts 88% 100% 80% 88% 27-32
packages/math/curve.ts 91.13% 83.33% 91.66% 91.13% 47-48, 60-61, 146-147, 165-166, 170-171, 233-234, 253-254, 263-273
packages/math/ellipse.ts 100% 100% 100% 100%
packages/math/index.ts 100% 100% 100% 100%
packages/math/line.ts 100% 100% 100% 100%
packages/math/point.ts 99.56% 94.73% 100% 99.56% 37
packages/math/rectangle.ts 100% 100% 100% 100%
packages/math/segment.ts 95.4% 89.65% 85.71% 95.4% 37-42, 89-90
packages/math/types.ts 100% 100% 100% 100%
packages/math/vector.ts 100% 100% 100% 100%
packages/utils/test-utils.ts 63.63% 50% 33.33% 63.63% 6-7, 17-26
Generated in workflow #4358 for commit f280768 by the Vitest Coverage Report Action

dwelle
dwelle reviewed Feb 25, 2025
View reviewed changes
dwelle
dwelle reviewed Feb 25, 2025
View reviewed changes
dwelle
dwelle reviewed Feb 25, 2025
View reviewed changes
dwelle
dwelle reviewed Feb 25, 2025
View reviewed changes
@mtolmacs mtolmacs merged commit 0ffeaea into master Feb 25, 2025
10 checks passed
@mtolmacs mtolmacs deleted the feat/remove-ga branch February 25, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mrazator Mrazator Mrazator left review comments

@ryan-di ryan-di ryan-di left review comments

@dwelle dwelle dwelle approved these changes

Assignees

@mtolmacs mtolmacs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mtolmacs @Mrazator @dwelle @ryan-di @Git21221 @tothatt81