Skip to content

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Jan 14, 2025

fix #8996

regressed in #8927

This is a hotfix and doesn't solve the underlying issue. We also want to keep normalizing the binding distance on pointerup, so we'll need to make a proper fix promptly.

@vercel
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jan 14, 2025 6:30pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jan 14, 2025 6:30pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jan 14, 2025 6:30pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 6:30pm

@github-actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.88% (🎯 60%) 67302 / 100621
🟢 Statements 66.88% (🎯 60%) 67302 / 100621
🟢 Functions 63.9% (🎯 63%) 1951 / 3053
🟢 Branches 79.61% (🎯 70%) 8041 / 10100
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/excalidraw/element/binding.ts 90.58% 88.13% 95.77% 90.58% 273, 291, 325, 336, 382-383, 646-647, 848, 855-857, 860-893, 906-919, 923-939, 943-965, 969-988, 1023-1024, 1026-1032, 1048-1054, 1070, 1072-1073, 1081-1086, 1126, 1280-1281, 1289-1290, 1295-1296, 1337, 1349-1350, 1375-1376, 1817-1818, 1845-1846, 1868-1869, 1921-1923, 2102-2103, 2214-2215, 2247-2251, 2287-2322, 2325-2334
Generated in workflow #4118 for commit cd8adb0 by the Vitest Coverage Report Action

@dwelle dwelle merged commit 46f42ef into master Jan 14, 2025
10 checks passed
@dwelle dwelle deleted the dwelle/hotfix-arrow-binding branch January 14, 2025 18:36
zsviczian added a commit to zsviczian/excalidraw that referenced this pull request Jan 14, 2025
fix: arrow binding behaving unexpectedly on pointerup (excalidraw#9010)
@zsviczian
Copy link
Collaborator

Unrelated to this PR... but the PR prompted me to share: It would be great to implement some arrow-binding locking feature. The binding behavior is very flaky. Also related: #8532

I more or less stopped using arrow binding (holding the CTRL modifier key all the time) because of all the frustrations with binding of arrows, and arrows rebinding to the top-level object and thus crippling the arrow constantly. An arrow-bind-lock would prevent the arrow from being bound to another object unless the user unlocks it first. This would make binding much more predictable (but of course, this could be just a needless workaround if binding would behave).

@dwelle
Copy link
Member Author

dwelle commented Jan 15, 2025

@zsviczian yes, the binding will be fully redesigned soon.

mtolmacs pushed a commit that referenced this pull request Jan 15, 2025
* fix: arrow binding behaving unexpectedly on pointerup

* update snaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arrows jump around unpredictably

3 participants