Skip to content

feat: implement custom Range component for opacity control #9009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 29, 2025
Merged

feat: implement custom Range component for opacity control #9009

merged 14 commits into from
Jan 29, 2025

Conversation

@Git21221
Copy link
Contributor

@Git21221 Git21221 commented Jan 14, 2025 •
edited by dwelle
Loading

2025-01-14.17-39-32.mp4

fix #8974

sample working of new opacity range
tested on: brave, chrome, edge, firefox (dark and white mode)

@vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jan 29, 2025 9:44pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jan 29, 2025 9:44pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jan 29, 2025 9:44pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 9:44pm

@Git21221
Copy link
Contributor Author

Git21221 commented Jan 18, 2025

@dwelle kindly review this PR, I will fix conflicts

@Git21221
Copy link
Contributor Author

Git21221 commented Jan 29, 2025

@dwelle why linting and test coverage is failing?

@dwelle
Copy link
Member

dwelle commented Jan 29, 2025

@dwelle why linting and test coverage is failing?

No clue. Will check. But in the meantime, the visuals are somewhat broken in mobile view:
image

@Git21221
Copy link
Contributor Author

Git21221 commented Jan 29, 2025

@dwelle now i used a fallback color, the issue was -button-bg is not available in mobile mode, so there is a new color called island-bg-color, I used that as a fallback, now it's working in mobile mode also, but the background will be same as other buttons on sidebar

@dwelle
Copy link
Member

dwelle commented Jan 29, 2025

pushed fixes for tests and lint. In the future, you can run yarn fix to autofix lint issues where applicable. It will log the rest into console.

@Git21221
Copy link
Contributor Author

Git21221 commented Jan 29, 2025

ok got it

@dwelle
Copy link
Member

dwelle commented Jan 29, 2025 •
edited
Loading

Alright, we're good to go. Thanks a lot! ❤️

You don't have Twitter? Couldn't find it.

@dwelle dwelle enabled auto-merge (squash) January 29, 2025 21:43
@dwelle dwelle merged commit bd1590f into excalidraw:master Jan 29, 2025
9 checks passed
@Git21221
Copy link
Contributor Author

Git21221 commented Jan 30, 2025

@dwelle I have, but don't use it that much. username: SaikatD04702748

mtolmacs pushed a commit that referenced this pull request Feb 6, 2025
@Git21221 @dwelle @mtolmacs
feat: implement custom Range component for opacity control (#9009)
7670d74 
Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
mtolmacs pushed a commit that referenced this pull request Feb 11, 2025
@Git21221 @dwelle @mtolmacs
feat: implement custom Range component for opacity control (#9009)
8831672 
Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
mtolmacs pushed a commit that referenced this pull request Feb 20, 2025
@Git21221 @dwelle @mtolmacs
feat: implement custom Range component for opacity control (#9009)
941a389 
Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opacity range redesigned

2 participants

@Git21221 @dwelle