Skip to content

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Jan 5, 2025

This change doesn't solve anything at the moment, it's just being more safe.

It's a BREAKING CHANGE in that it escapes more characters now, which carries over to element link (and related) sanitization where we use this util as well.

@vercel
Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jan 5, 2025 5:44pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jan 5, 2025 5:44pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jan 5, 2025 5:44pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2025 5:44pm

@github-actions
Copy link

github-actions bot commented Jan 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.94% (🎯 60%) 67230 / 100424
🟢 Statements 66.94% (🎯 60%) 67230 / 100424
🟢 Functions 63.93% (🎯 63%) 1950 / 3050
🟢 Branches 79.64% (🎯 70%) 8034 / 10087
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/excalidraw/utils.ts 78.22% 86.02% 74.71% 78.22% 83-85, 100-101, 137-139, 153-163, 170-175, 179-181, 183-185, 190-192, 275-276, 310, 338-351, 354-361, 364-368, 397, 405, 408, 418-421, 469, 493-498, 506-507, 524-525, 566-582, 585-589, 593-606, 620-622, 624-625, 628-629, 632-640, 643-646, 702-722, 729, 732-738, 778-779, 806, 850-856, 861-878, 890-896, 925-938, 942-943, 989-999, 1010-1011, 1078-1079, 1087-1117, 1174-1179
packages/excalidraw/data/url.ts 44.44% 50% 33.33% 44.44% 7-8, 13-14, 21-36
packages/excalidraw/element/embeddable.ts 32.14% 20% 42.85% 32.14% 88-89, 92-285, 288-322, 330-349, 363-380, 390-391, 395-396, 400-401, 404-405, 409-410, 420-421, 423-445
Generated in workflow #4052 for commit 979e0ab by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants