Skip to content

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Jan 5, 2025

  • BREAKING CHANGE: only allow *.excalidraw.com base domain library install urls by default, for safety reasons.
  • new API for useHandleLibrary() hook: opts.validateLibraryUrl(libraryUrl: string): boolean. If supplied, the libraryUrl is allowed only if returned true

@vercel
Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jan 5, 2025 4:07pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jan 5, 2025 4:07pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jan 5, 2025 4:07pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2025 4:07pm

@dwelle dwelle force-pushed the dwelle/validate-library-urls branch from 3befe8d to 031ec20 Compare January 5, 2025 16:05
@github-actions
Copy link

github-actions bot commented Jan 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.94% (🎯 60%) 67217 / 100411
🟢 Statements 66.94% (🎯 60%) 67217 / 100411
🟢 Functions 63.93% (🎯 63%) 1950 / 3050
🟢 Branches 79.66% (🎯 70%) 8041 / 10094
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/excalidraw/data/library.ts 68.44% 67.81% 75.86% 68.44% 108-120, 158-161, 219-220, 250, 255-256, 286-287, 299-303, 306-310, 315-316, 318-319, 321-322, 357-358, 361-365, 474-493, 504, 510-513, 524-525, 531-532, 534-554, 563, 571-631, 675-735, 737-749, 758-759, 764, 766-785, 817-819, 829-844, 848-850, 854-857, 917-918, 921-934, 939-942
Generated in workflow #4049 for commit 031ec20 by the Vitest Coverage Report Action

@sentry
Copy link

sentry bot commented Jan 13, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Invalid or disallowed library URL validateLibraryUrl(packages/excalidraw/data/lib... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants