Skip to content

fix: make arrow binding area adapt to zoom levels #8927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 22, 2024
Merged

fix: make arrow binding area adapt to zoom levels #8927

merged 4 commits into from
Dec 22, 2024

Conversation

@ryan-di
Copy link
Member

@ryan-di ryan-di commented Dec 19, 2024 •
edited
Loading

  • make binding area / highlight thickness adaptive to zoom
  • normalize arrowhead position on pointer up
  • normalize arrowhead position on pointer move

@vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Dec 20, 2024 10:48am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Dec 20, 2024 10:48am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Dec 20, 2024 10:48am
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 10:48am

@github-actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.87% (🎯 60%) 66909 / 100053
🟢 Statements 66.87% (🎯 60%) 66909 / 100053
🟢 Functions 63.94% (🎯 63%) 1947 / 3045
🟢 Branches 79.62% (🎯 70%) 7990 / 10035
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/excalidraw/actions/actionDeleteSelected.tsx 82.8% 74.28% 83.33% 82.8% 45-56, 63-64, 117-118, 124-125, 129-145, 151, 177, 205
packages/excalidraw/actions/actionFlip.ts 100% 96.15% 100% 100%
packages/excalidraw/actions/actionProperties.tsx 78.62% 81.03% 87.69% 78.62% 199-201, 241-242, 276, 425-427, 443-452, 689, 775-801, 813-840, 866-867, 869-870, 882, 898-900, 938-961, 989, 1003, 1005-1009, 1015-1017, 1060-1065, 1067-1072, 1074-1134, 1163-1164, 1216, 1254-1255, 1304, 1329-1330, 1337, 1340, 1470-1502, 1554-1692, 1738-1739
packages/excalidraw/components/App.tsx 69.67% 76.56% 71.5% 69.67% 510-511, 623-632, 732-733, 751-752, 773-833, 836-842, 855-858, 861-937, 940-959, 962-967, 975-985, 987-988, 993-994, 998-1000, 1014, 1021-1286, 1346-1347, 1379-1381, 1388-1433, 1459, 1469, 1476-1479, 1488-1492, 1523-1524, 1609-1619, 1624-1639, 1643-1690, 1786-1791, 1820-1825, 1828-1858, 1866-1891, 1904-1995, 1998-2006, 2009-2068, 2071-2112, 2115-2120, 2155-2156, 2179-2180, 2212-2213, 2217-2218, 2238-2246, 2251-2264, 2270-2271, 2275, 2280-2288, 2290-2298, 2310, 2345-2346, 2359-2360, 2382-2383, 2390, 2411-2413, 2473-2475, 2478-2483, 2488-2489, 2529-2537, 2542-2551, 2595-2597, 2700-2701, 2705, 2708-2709, 2717-2720, 2729-2742, 2748-2751, 2754, 2756-2757, 2764-2765, 2771-2772, 2775-2776, 2787, 2789-2793, 2796-2797, 2800-2801, 2812-2820, 2825-2826, 2877-2878, 2892-2898, 2904-2912, 2916-2924, 2928-2929, 2932-2965, 2968-2980, 2991-2992, 3003-3004, 3021-3025, 3029-3032, 3039-3041, 3059-3066, 3069, 3071-3076, 3080-3082, 3128-3129, 3136-3138, 3140-3163, 3180-3216, 3231, 3237, 3294-3297, 3300-3301, 3318-3320, 3342-3343, 3349-3353, 3359-3440, 3494, 3498, 3533-3534, 3593, 3603-3621, 3624-3630, 3633-3634, 3640-3656, 3696-3721, 3804-3805, 3828-3842, 3850-3856, 3870-3871, 3877-3890, 3947-3948, 4020-4030, 4066, 4215-4216, 4218-4225, 4259-4263, 4265-4266, 4268-4271, 4292-4293, 4300-4301, 4323-4333, 4343-4345, 4347, 4430-4433, 4455-4463, 4467-4469, 4479-4480, 4482-4502, 4509-4532, 4535-4541, 4558-4561, 4576-4583, 4680-4684, 4688, 4693-4694, 4699-4703, 4736-4737, 4740-4741, 4753-4757, 4762-4763, 4769-4779, 4784-4811, 4816-4827, 4927-4928, 5012, 5037, 5063-5065, 5132-5133, 5151-5152, 5343-5344, 5347-5348, 5356-5357, 5412-5416, 5469-5476, 5478-5479, 5484-5550, 5594, 5651, 5678, 5685-5686, 5699-5702, 5733, 5786-5789, 5792-5796, 5798-5805, 5822-5831, 5834-5835, 5971-5972, 5975, 5977-5982, 5988-5990, 5992, 6001, 6003, 6025-6030, 6032-6035, 6039-6040, 6049-6065, 6067, 6069-6072, 6076-6172, 6176-6177, 6192-6193, 6229-6235, 6262-6263, 6275-6276, 6304, 6306-6336, 6343-6344, 6366-6367, 6386, 6388-6431, 6436-6437, 6439-6440, 6456-6457, 6463-6464, 6468-6471, 6474-6475, 6489-6515, 6523-6524, 6528-6531, 6533-6537, 6555-6559, 6606-6611, 6613-6615, 6631, 6633-6646, 6671-6674, 6729, 6746-6747, 6749-6772, 6787-6788, 6902-6930, 6985-6986, 7049-7050, 7066-7067, 7086-7087, 7181, 7187-7188, 7211-7230, 7239-7248, 7262, 7411-7449, 7453-7503, 7518, 7527, 7561-7567, 7594-7596, 7763-7766, 7788-7818, 7831, 7833-7841, 7855, 7857-7865, 7872-7875, 7883-7888, 7897-7898, 7923-7924, 7927-7929, 7932-7933, 7956-7957, 7963-7964, 7991-7992, 8075-8076, 8127-8140, 8144-8230, 8310-8313, 8339-8340, 8397, 8420-8426, 8437-8457, 8485-8491, 8523, 8565, 8571, 8586-8593, 8596-8603, 8658, 8736-8737, 8758-8760, 8763, 8777-8801, 8910-8923, 8946-8970, 8979-9018, 9031-9032, 9041-9048, 9066-9073, 9127-9132, 9141-9165, 9167-9168, 9242-9243, 9250, 9252-9288, 9317, 9376, 9416-9418, 9443-9448, 9450-9451, 9456-9458, 9461-9481, 9495-9496, 9502-9511, 9516, 9520-9524, 9533-9537, 9540-9545, 9549-9556, 9585, 9587-9591, 9593-9603, 9619-9621, 9632-9640, 9644-9688, 9691-9762, 9770, 9788-9795, 9797-9819, 9834-9856, 9875-9877, 9924-9925, 10038-10042, 10044-10060, 10062-10066, 10078-10079, 10089-10105, 10124-10143, 10145-10146, 10173-10174, 10178-10179, 10189, 10191-10194, 10196-10197, 10237, 10278-10279, 10289, 10331, 10349-10357, 10368-10373, 10383-10384, 10386-10457, 10480-10481, 10513-10516, 10610-10617, 10643-10644, 10692-10763, 10811-10812, 10821-10824, 10829-10830, 10851-10853, 10855-10859, 10897
packages/excalidraw/components/Stats/utils.ts 84.32% 76.47% 100% 84.32% 136-137, 142-152, 180-199, 206-209, 225-226, 261-271
packages/excalidraw/element/binding.ts 90.6% 88.3% 95.77% 90.6% 272, 290, 324, 335, 381-382, 651-652, 853, 860-862, 865-898, 911-924, 928-944, 948-970, 974-993, 1028-1029, 1031-1037, 1053-1059, 1075, 1077-1078, 1086-1091, 1131, 1285-1286, 1294-1295, 1300-1301, 1342, 1354-1355, 1380-1381, 1822-1823, 1850-1851, 1873-1874, 1926-1928, 2107-2108, 2219-2220, 2252-2256, 2292-2327, 2330-2339
packages/excalidraw/element/linearElementEditor.ts 75.92% 81.53% 86.48% 75.92% 112-113, 155, 159-216, 232-233, 238-239, 243-244, 246-247, 250-263, 266-268, 279-280, 282-307, 332-335, 406-407, 432, 453, 471-479, 567-568, 688-689, 702, 728-729, 735-736, 753-797, 899-900, 904-905, 912-918, 924-926, 928-976, 1140-1141, 1144-1219, 1235-1242, 1265-1281, 1365-1366, 1369-1370, 1409-1410, 1475, 1482, 1526-1563, 1680-1712
packages/excalidraw/element/routing.ts 89.18% 84.64% 100% 89.18% 104-105, 199, 238, 246-250, 257, 262-266, 310-311, 314-315, 342-344, 392-394, 441, 445-446, 481-483, 518-519, 594-613, 630-677, 776-777, 782-783, 818-819, 831-832, 857-858, 862-863, 865-866, 875-876, 937-939
packages/excalidraw/renderer/interactiveScene.ts 88.5% 84.61% 86.36% 88.5% 95-96, 100-101, 147-148, 161-179, 264-275, 290-317, 395, 465-467, 488-489, 533-540, 592-603, 748-749, 800-801, 871-873, 916, 929-938, 959, 1104-1107, 1141-1164
Generated in workflow #3960 for commit 9b13ff9 by the Vitest Coverage Report Action

@ryan-di ryan-di marked this pull request as ready for review December 20, 2024 10:46
@ryan-di ryan-di requested a review from dwelle December 20, 2024 10:46
dwelle
dwelle approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, cool. Let's leave the pointermove on a future PR! 👍

@dwelle dwelle merged commit 1e3399e into master Dec 22, 2024
10 checks passed
@dwelle dwelle deleted the ryan-di/fix-arrow-binding-area branch December 22, 2024 21:55
@sentry
Copy link

sentry bot commented Dec 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: null is not an object (evaluating 't[0]') mulScalar(packages/math/ga/ga) View Issue

Did you find this useful? React with a 👍 or 👎

mtolmacs added a commit that referenced this pull request Dec 25, 2024
@mtolmacs
fix: make arrow binding area adapt to zoom levels (#8927)
b9a2cc4 
* make binding area adapt to zoom

* revert stroke color

* normalize binding gap

* reduce normalized gap
mtolmacs pushed a commit that referenced this pull request Dec 26, 2024
@ryan-di @mtolmacs
fix: make arrow binding area adapt to zoom levels (#8927)
e7ef0b4 
* make binding area adapt to zoom

* revert stroke color

* normalize binding gap

* reduce normalized gap
This was referenced Dec 30, 2024
Closed
Closed
@zsviczian
Copy link
Collaborator

zsviczian commented Dec 30, 2024

@dwelle, this PR introduced a regression. Elbow connectors no longer work in frames.
see: #8964

@zsviczian zsviczian mentioned this pull request Jan 3, 2025
Merged
@dwelle dwelle mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ryan-di @zsviczian @dwelle