Skip to content

fix: regression on dragging a selected frame by its name #8924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2024
Merged

fix: regression on dragging a selected frame by its name #8924

merged 1 commit into from
Dec 22, 2024

Conversation

@ryan-di
Copy link
Member

@ryan-di ryan-di commented Dec 18, 2024

close #8915

@vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Dec 18, 2024 3:32am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Dec 18, 2024 3:32am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Dec 18, 2024 3:32am
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Dec 18, 2024 3:32am

@ryan-di ryan-di mentioned this pull request Dec 18, 2024
Closed
@github-actions
Copy link

github-actions bot commented Dec 18, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.84% (🎯 60%) 66803 / 99937
🟢 Statements 66.84% (🎯 60%) 66803 / 99937
🟢 Functions 63.92% (🎯 63%) 1946 / 3044
🟢 Branches 79.6% (🎯 70%) 7973 / 10016
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/excalidraw/components/App.tsx 69.68% 76.54% 71.5% 69.68% 510-511, 623-632, 732-733, 751-752, 773-833, 836-842, 855-858, 861-937, 940-959, 962-967, 975-985, 987-988, 993-994, 998-1000, 1014, 1021-1286, 1346-1347, 1379-1381, 1388-1433, 1459, 1469, 1476-1479, 1488-1492, 1523-1524, 1609-1619, 1624-1639, 1643-1690, 1786-1791, 1820-1825, 1828-1858, 1866-1891, 1904-1995, 1998-2006, 2009-2068, 2071-2112, 2115-2120, 2155-2156, 2179-2180, 2212-2213, 2217-2218, 2238-2246, 2251-2264, 2270-2271, 2275, 2280-2288, 2290-2298, 2310, 2345-2346, 2359-2360, 2382-2383, 2390, 2411-2413, 2473-2475, 2478-2483, 2488-2489, 2529-2537, 2542-2551, 2595-2597, 2700-2701, 2705, 2708-2709, 2717-2720, 2729-2742, 2748-2751, 2754, 2756-2757, 2764-2765, 2771-2772, 2775-2776, 2787, 2789-2793, 2796-2797, 2800-2801, 2812-2820, 2825-2826, 2877-2878, 2892-2898, 2904-2912, 2916-2924, 2928-2929, 2932-2965, 2968-2980, 2991-2992, 3003-3004, 3021-3025, 3029-3032, 3039-3041, 3059-3066, 3069, 3071-3076, 3080-3082, 3128-3129, 3136-3138, 3140-3163, 3180-3212, 3227, 3233, 3290-3293, 3296-3297, 3314-3316, 3338-3339, 3345-3349, 3355-3436, 3490, 3494, 3529-3530, 3589, 3599-3617, 3620-3626, 3629-3630, 3636-3652, 3692-3717, 3800-3801, 3824-3838, 3846-3852, 3866-3867, 3873-3886, 3943-3944, 4016-4026, 4062, 4211-4212, 4214-4221, 4255-4259, 4261-4262, 4264-4267, 4288-4289, 4296-4297, 4319-4329, 4339-4341, 4343, 4424-4427, 4449-4457, 4461-4463, 4473-4474, 4476-4496, 4503-4526, 4529-4535, 4552-4555, 4570-4577, 4673-4677, 4681, 4686-4687, 4692-4696, 4729-4730, 4733-4734, 4746-4750, 4755-4756, 4762-4772, 4777-4804, 4809-4820, 4920-4921, 5005, 5030, 5056-5058, 5129-5130, 5148-5149, 5340-5341, 5344-5345, 5353-5354, 5409-5413, 5466-5473, 5475-5476, 5481-5547, 5591, 5648, 5675, 5682-5683, 5696-5699, 5730, 5783-5786, 5789-5793, 5795-5802, 5819-5828, 5831-5832, 5967-5968, 5971, 5973-5978, 5984-5986, 5988, 5997, 5999, 6021-6026, 6028-6031, 6035-6036, 6045-6061, 6063, 6065-6068, 6072-6168, 6172-6173, 6188-6189, 6225-6231, 6258-6259, 6271-6272, 6300, 6302-6332, 6339-6340, 6362-6363, 6382, 6384-6427, 6432-6433, 6435-6436, 6452-6453, 6459-6460, 6464-6467, 6470-6471, 6485-6511, 6519-6520, 6524-6527, 6529-6533, 6551-6555, 6602-6607, 6609-6611, 6627, 6629-6642, 6667-6670, 6725, 6742-6743, 6745-6768, 6783-6784, 6898-6926, 6981-6982, 7045-7046, 7062-7063, 7082-7083, 7177, 7183-7184, 7207-7226, 7235-7244, 7258, 7406-7444, 7448-7498, 7513, 7522, 7556-7562, 7589-7591, 7757-7760, 7782-7812, 7825, 7827-7835, 7849, 7851-7859, 7866-7869, 7877-7882, 7891-7892, 7917-7918, 7921-7923, 7926-7927, 7950-7951, 7957-7958, 7985-7986, 8069-8070, 8121-8134, 8138-8224, 8303-8306, 8332-8333, 8390, 8413-8419, 8430-8449, 8477-8483, 8515, 8557, 8563, 8578-8585, 8588-8595, 8650, 8728-8729, 8750-8752, 8755, 8769-8793, 8902-8915, 8938-8962, 8971-9010, 9023-9024, 9033-9040, 9058-9065, 9119-9124, 9133-9157, 9159-9160, 9234-9235, 9242, 9244-9280, 9309, 9368, 9407-9409, 9434-9439, 9441-9442, 9447-9449, 9452-9472, 9486-9487, 9493-9502, 9507, 9511-9515, 9524-9528, 9531-9536, 9540-9547, 9576, 9578-9582, 9584-9594, 9610-9612, 9623-9631, 9635-9679, 9682-9753, 9761, 9779-9786, 9788-9810, 9825-9847, 9866-9868, 9914-9915, 10027-10031, 10033-10049, 10051-10055, 10067-10068, 10078-10094, 10113-10132, 10134-10135, 10162-10163, 10167-10168, 10178, 10180-10183, 10185-10186, 10226, 10267-10268, 10278, 10320, 10338-10346, 10357-10362, 10372-10373, 10375-10446, 10469-10470, 10502-10505, 10598-10605, 10631-10632, 10680-10751, 10799-10800, 10809-10812, 10817-10818, 10839-10841, 10843-10847, 10885
Generated in workflow #3951 for commit 0bc7625 by the Vitest Coverage Report Action

@ryan-di ryan-di requested a review from dwelle December 20, 2024 14:42
dwelle
dwelle approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dwelle dwelle merged commit 606ac6c into master Dec 22, 2024
10 checks passed
@dwelle dwelle deleted the ryan-di/fix-frame-drag branch December 22, 2024 21:47
mtolmacs added a commit that referenced this pull request Dec 25, 2024
@mtolmacs
fix: regression on dragging a selected frame by its name (#8924)
a87ff50 
fix hit element check for a selected frame's name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

frame title not draggable when frame selected

3 participants

@ryan-di @dwelle