Skip to content

build: add a flag VITE_APP_ENABLE_PWA for enabling pwa in dev environment #8784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2024
Merged

build: add a flag VITE_APP_ENABLE_PWA for enabling pwa in dev environment #8784

merged 3 commits into from
Nov 9, 2024

Conversation

@ad1992
Copy link
Member

@ad1992 ad1992 commented Nov 9, 2024 •
edited
Loading

  • add a flag VITE_APP_ENABLE_PWA for enabling pwa in dev environment
  • Add id which was missing from the manifest

@vercel
Copy link

vercel bot commented Nov 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Nov 9, 2024 4:13pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Nov 9, 2024 4:13pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Nov 9, 2024 4:13pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 4:13pm

@ad1992 ad1992 requested a review from dwelle November 9, 2024 11:05
@github-actions
Copy link

github-actions bot commented Nov 9, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 67.23% (🎯 60%) 66458 / 98846
🟢 Statements 67.23% (🎯 60%) 66458 / 98846
🟢 Functions 64.12% (🎯 63%) 1941 / 3027
🟢 Branches 80% (🎯 70%) 7938 / 9922
File CoverageNo changed files found.
Generated in workflow #3785 for commit 8535ad5 by the Vitest Coverage Report Action

dwelle
dwelle approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about adding VITE_APP_ENABLE_PWA=false in .env.development to make it discoverable?

@ad1992
Copy link
Member Author

ad1992 commented Nov 9, 2024

how about adding VITE_APP_ENABLE_PWA=false in .env.development to make it discoverable?
yep done

@ad1992 ad1992 merged commit ee091d0 into master Nov 9, 2024
10 checks passed
@ad1992 ad1992 deleted the aakansha/pwa branch November 9, 2024 16:15
@dwelle dwelle mentioned this pull request Nov 9, 2024
Merged
tinnitusi pushed a commit to ndy-onl/gamifyboard that referenced this pull request Jul 21, 2025
@ad1992
build: add a flag VITE_APP_ENABLE_PWA for enabling pwa in dev environ…
ac832b3 
…ment (excalidraw#8784)

* build: add a flag VITE_APP_ENABLE_PWA for enabling pwa in dev environment

* fix

* set VITE_ENABLE_PWA to false in .env.development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ad1992 @dwelle