Skip to content

fix: image render perf #8697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: image render perf #8697

merged 1 commit into from
Oct 23, 2024

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Oct 23, 2024

fix #8692

@vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Oct 23, 2024 9:47am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Oct 23, 2024 9:47am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Oct 23, 2024 9:47am
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 23, 2024 9:47am

@dwelle dwelle requested a review from ryan-di October 23, 2024 09:45
@github-actions
Copy link

github-actions bot commented Oct 23, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 67.25% (🎯 60%) 66005 / 98135
🟢 Statements 67.25% (🎯 60%) 66005 / 98135
🟢 Functions 64% (🎯 63%) 1913 / 2989
🟢 Branches 79.98% (🎯 70%) 7887 / 9860
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/renderer/renderElement.ts 81.6% 78.14% 100% 81.6% 90-92, 186-187, 191-192, 218-219, 254-255, 370, 416-417, 430-461, 472-475, 489, 512-513, 515-516, 569-570, 648, 650-663, 726-728, 756-766, 775-776, 811-819, 825-826, 830-893, 918-919, 949-971, 987-989, 1011, 1014, 1041-1042
Generated in workflow #3670 for commit 310233d by the Vitest Coverage Report Action

ryan-di
ryan-di approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@ryan-di ryan-di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@dwelle dwelle merged commit 958e03f into master Oct 23, 2024
10 checks passed
@dwelle dwelle deleted the dwelle/fix-image-perf branch October 23, 2024 09:58
zsviczian added a commit to zsviczian/excalidraw that referenced this pull request Oct 23, 2024
@zsviczian
Merge pull request #265 from excalidraw/master
653a32e 
fix: image render perf (excalidraw#8697)
Jauhen pushed a commit to Jauhen/excalidraw that referenced this pull request Nov 12, 2024
@dwelle @Jauhen
fix: image render perf (excalidraw#8697)
2d5d5df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryan-di ryan-di ryan-di approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: Regression with image cropper - serious performance degradation when many images are in the scene

3 participants

@dwelle @ryan-di