-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
fix: load font faces in Safari manually #8693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
e950bae to
013d0ec
Compare
013d0ec to
863e87c
Compare
863e87c to
db2b63f
Compare
db2b63f to
9106fb2
Compare
9106fb2 to
52b309b
Compare
dwelle
approved these changes
Oct 30, 2024
mtolmacs
pushed a commit
that referenced
this pull request
Nov 1, 2024
Jauhen
pushed a commit
to Jauhen/excalidraw
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari does not always trigger "loadingdone" event (actually it rarely does) and thus in most cases we end up with unloaded fonts on init and paste. It's especially annoying when there are tons of font faces to load, such as with the recent CJK support and half or even less characters remain unloaded.
The solution is loading all the necessary font faces manually in Safari, both on init and when pasting elements.
Fixes #3229
Other improvements
FontsclassTODO
Follows #8530