fix: #8575 , Flowchart clones the current arrowhead #8581

ashwintemkar · 2024-10-02T11:39:08Z

FIXES

DEMO

2024-10-02.15-26-39.mp4

vercel · 2024-10-02T11:39:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
excalidraw	✅ Ready (Inspect)	Visit Preview	Oct 2, 2024 1:31pm
excalidraw-package-example	✅ Ready (Inspect)	Visit Preview	Oct 2, 2024 1:31pm
excalidraw-package-example-with-nextjs	✅ Ready (Inspect)	Visit Preview	Oct 2, 2024 1:31pm

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
docs	⬜️ Ignored (Inspect)	Visit Preview	Oct 2, 2024 1:31pm

mtolmacs · 2024-10-02T11:50:48Z

Yes, it works. Can you also make sure that the arrow uses the stroke and color of the starting shape instead of the global arrow setting?

ashwintemkar · 2024-10-02T12:01:23Z

Yes, it works. Can you also make sure that the arrow uses the stroke and color of the starting shape instead of the global arrow setting?

I have a few doubts on the same where in the current cone is using the stroke and color of the starting shape like this

on changing it again in the global settings it takes that color
like this

I think that would be another issue to solve to stop making the color of the global arrow to intefere after changing it specifically

below is the demo of the same process

DEMO

2024-10-02.15-59-13.mp4

mtolmacs · 2024-10-02T12:06:33Z

I'm not sure what you're saying, but the goal would be to override the color, stroke and sloppyness of the arrow with the starting shape values, not get it from the global settings.

The arrowhead part looks perfect, we just need to unify the the flowchart arrow style with the starting shape and its good to go.

ashwintemkar · 2024-10-02T12:21:36Z

I'm not sure what you're saying, but the goal would be to override the color, stroke and sloppyness of the arrow with the starting shape values, not get it from the global settings.

The arrowhead part looks perfect, we just need to unify the the flowchart arrow style with the starting shape and its good to go.

so Yes the current the color, stroke and sloppyness of the arrow comes is being taken from the staring shape,

for eg:

current situation

starting shap's color and stroke: red
global Arrow's color and stroke: white
flowchart arrow color and stroke: Same as 1.

On change of the global arrow once again

starting shap's color and stroke: red
global Arrow's color and stroke: white
flowchart arrow color and stroke: white.

can you confirm if you need whether

On change of the global arrow once again

starting shap's color and stroke: red
global Arrow's color and stroke: white
flowchart arrow color and stroke: Same as 1.

mtolmacs

Make the attributes come from the starting shape (including the sloppiness, which is currently not set).

mtolmacs · 2024-10-02T13:00:19Z

packages/excalidraw/element/flowchart.ts

-    startArrowhead: appState.currentItemStartArrowhead,
+    startArrowhead: null,
    endArrowhead: appState.currentItemEndArrowhead,
    strokeColor: appState.currentItemStrokeColor,


Use the starting (startBindingElement) stroke color instead of appState.currentItemStrokeColor

mtolmacs · 2024-10-02T13:00:42Z

packages/excalidraw/element/flowchart.ts

+    startArrowhead: null,
    endArrowhead: appState.currentItemEndArrowhead,
    strokeColor: appState.currentItemStrokeColor,
    strokeStyle: appState.currentItemStrokeStyle,


Use the starting (startBindingElement) stroke style instead of appState.currentItemStrokeStyle

mtolmacs · 2024-10-02T13:08:03Z

The current situation is that the arrow color, style and sloppiness comes from the global app state. Please check it out again, you'll see that if you previously changed the color to white it will create a white arrow, even though the starting shape was red:

…indingElement

ashwintemkar · 2024-10-02T13:32:04Z

can you please check it now ? I have updated the PR

mtolmacs · 2024-10-02T14:02:19Z

Awsome, thanks! @dwelle I believe this is ready for your review.

Mistake

ashwintemkar · 2024-10-04T05:39:40Z

@mtolmacs is anything pending from my side? on this issue as I am not able to see any activity in this PR since 2 days, I think it is pending @dwelle 's review right? after which this might get merged?

mtolmacs · 2024-10-04T14:12:54Z

Yes, nothing else for the moment.

ashwintemkar · 2024-10-07T09:11:49Z

@mtolmacs and @dwelle I wanted to check in on the status of the PR – it hasn't been merged yet, and I was wondering if you might have an estimate for when it might be completed?

mtolmacs · 2024-10-08T08:47:38Z

Hi @rothardo it will be done when dwelle has time to review it. No need to ping him, I'm tracking all the PRs I reviewed.

ashwintemkar · 2025-01-13T08:38:14Z

Hi @mtolmacs, It has been quite a while since this PR was submitted, may I know the status of it,
even though you said,

Hi @rothardo it will be done when dwelle has time to review it. No need to ping him, I'm tracking all the PRs I reviewed.

I gave not seen anything change since , is there anything needed from my side? then please let me know, I shall do it

dwelle · 2025-01-24T15:49:51Z

Thank you, and really sorry for taking so long 😊

A followup issue could be to make sure the other rectangle also copies the attributes of the starting rectangle.

ashwintemkar · 2025-01-24T16:09:59Z

Thank you, and really sorry for taking so long 😊

A followup issue could be to make sure the other rectangle also copies the attributes of the starting rectangle.

so, are you opening up an issue on the same?

then I am ready to take that issue and work on it?

dwelle · 2025-01-24T16:44:55Z

@rothardo #9045 👍

fix: excalidraw#8575, Flowchart clones the current arrowhead

1b799be

vercel bot deployed to Preview – excalidraw-package-example October 2, 2024 11:40 View deployment

vercel bot deployed to Preview – excalidraw October 2, 2024 11:40 View deployment

ashwintemkar changed the title ~~fix: #8575, Flowchart clones the current arrowhead~~ fix: #8575 , Flowchart clones the current arrowhead Oct 2, 2024

vercel bot deployed to Preview – excalidraw-package-example-with-nextjs October 2, 2024 11:41 View deployment

mtolmacs linked an issue Oct 2, 2024 that may be closed by this pull request

Flowchart clones the current arrowhead settings instead of setting no arrowhead on the start and arrowhead at the end #8575

Closed

mtolmacs mentioned this pull request Oct 2, 2024

fix: flowchart reusing current arrowhead settings #8576

Closed

mtolmacs requested changes Oct 2, 2024

View reviewed changes

fix: excalidraw#8575, changed stroke color, style and width to startB…

91fe80d

…indingElement

vercel bot deployed to Preview – excalidraw-package-example October 2, 2024 13:30 View deployment

vercel bot deployed to Preview – excalidraw October 2, 2024 13:30 View deployment

vercel bot deployed to Preview – excalidraw-package-example-with-nextjs October 2, 2024 13:31 View deployment

mtolmacs self-requested a review October 2, 2024 14:02

mtolmacs previously approved these changes Oct 2, 2024

View reviewed changes

dwelle approved these changes Jan 24, 2025

View reviewed changes

dwelle merged commit 8f20b29 into excalidraw:master Jan 24, 2025
8 checks passed

ashwintemkar mentioned this pull request Jan 24, 2025

flowcharts: align attributes of new node (rectangle) #9045

Closed

Uh oh!

fix: #8575 , Flowchart clones the current arrowhead #8581

fix: #8575 , Flowchart clones the current arrowhead #8581

Uh oh!

Conversation

ashwintemkar commented Oct 2, 2024

FIXES

DEMO

Uh oh!

vercel bot commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtolmacs commented Oct 2, 2024

Uh oh!

ashwintemkar commented Oct 2, 2024

Uh oh!

mtolmacs commented Oct 2, 2024

Uh oh!

ashwintemkar commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

current situation

On change of the global arrow once again

can you confirm if you need whether

On change of the global arrow once again

Uh oh!

mtolmacs left a comment

Choose a reason for hiding this comment

Uh oh!

mtolmacs Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

ashwintemkar Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

mtolmacs Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

ashwintemkar Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

mtolmacs commented Oct 2, 2024

Uh oh!

ashwintemkar commented Oct 2, 2024

Uh oh!

mtolmacs commented Oct 2, 2024

Uh oh!

ashwintemkar commented Oct 4, 2024

Uh oh!

mtolmacs commented Oct 4, 2024

Uh oh!

ashwintemkar commented Oct 7, 2024

Uh oh!

mtolmacs commented Oct 8, 2024

Uh oh!

ashwintemkar commented Jan 13, 2025

Uh oh!

dwelle commented Jan 24, 2025

Uh oh!

Uh oh!

ashwintemkar commented Jan 24, 2025

Uh oh!

dwelle commented Jan 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Oct 2, 2024 •

edited

Loading

ashwintemkar commented Oct 2, 2024 •

edited

Loading