Skip to content

feat: self-hosting existing google fonts #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: self-hosting existing google fonts #8540

merged 1 commit into from
Sep 24, 2024

Conversation

@Mrazator
Copy link
Member

@Mrazator Mrazator commented Sep 23, 2024 •
edited by dwelle
Loading

  • @dwelle fonts will need to be uploaded to our CDN
  • removed support for https imports

@vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Sep 24, 2024 0:25am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Sep 24, 2024 0:25am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Sep 24, 2024 0:25am
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 0:25am

@Mrazator Mrazator force-pushed the mrazator/self-host-google-fonts branch from 08713c4 to 5ad53f5 Compare September 23, 2024 19:41
@Mrazator Mrazator force-pushed the mrazator/self-host-google-fonts branch from 5ad53f5 to 916ada0 Compare September 23, 2024 19:52
@Mrazator Mrazator force-pushed the mrazator/self-host-google-fonts branch from 916ada0 to 09241fc Compare September 23, 2024 20:08
@github-actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 64.34% (🎯 60%) 60631 / 94226
🟢 Statements 64.34% (🎯 60%) 60631 / 94226
🟢 Functions 68.21% (🎯 63%) 1764 / 2586
🟢 Branches 81.06% (🎯 70%) 7521 / 9278
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/fonts/index.ts 86.35% 87.87% 93.33% 86.35% 58-64, 70-71, 93-98, 103-121, 177-190, 340
scripts/buildPackage.js 0% 0% 0% 0% 1-135
scripts/buildUtils.js 0% 0% 0% 0% 1-131
scripts/woff2/woff2-esbuild-plugins.js 0% 0% 0% 0% 1-208
scripts/woff2/woff2-vite-plugins.js 0% 0% 0% 0% 1-112
Generated in workflow #3384

@Mrazator Mrazator requested a review from dwelle September 23, 2024 20:18
@Mrazator Mrazator marked this pull request as ready for review September 23, 2024 20:18
@Mrazator Mrazator marked this pull request as draft September 24, 2024 08:02
@Mrazator Mrazator force-pushed the mrazator/self-host-google-fonts branch from 09241fc to 20dc1df Compare September 24, 2024 09:37
@Mrazator Mrazator force-pushed the mrazator/self-host-google-fonts branch from 20dc1df to abbf44c Compare September 24, 2024 09:41
@Mrazator Mrazator marked this pull request as ready for review September 24, 2024 10:11
@Mrazator Mrazator force-pushed the mrazator/self-host-google-fonts branch 3 times, most recently from 7206cd9 to bb69b34 Compare September 24, 2024 10:27
@Mrazator Mrazator force-pushed the mrazator/self-host-google-fonts branch from bb69b34 to d45e019 Compare September 24, 2024 12:22
@dwelle
Copy link
Member

dwelle commented Sep 24, 2024

Thanks!

@dwelle dwelle merged commit a80cb58 into master Sep 24, 2024
11 checks passed
@dwelle dwelle deleted the mrazator/self-host-google-fonts branch September 24, 2024 15:30
Mrazator added a commit that referenced this pull request Sep 24, 2024
@Mrazator
feat: self-hosting existing google fonts (#8540)
03ff17f
Mrazator added a commit to dwelle/excalidraw that referenced this pull request Sep 25, 2024
@Mrazator
feat: self-hosting existing google fonts (excalidraw#8540)
489f1aa
clarencechaan pushed a commit to clarencechaan/excalidraw that referenced this pull request Oct 3, 2024
@Mrazator @clarencechaan
feat: self-hosting existing google fonts (excalidraw#8540)
af6ceb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mrazator @dwelle