Skip to content

feat: flip arrowheads if only arrow(s) selected #8525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2024
Merged

feat: flip arrowheads if only arrow(s) selected #8525

merged 2 commits into from
Sep 19, 2024

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Sep 19, 2024 •
edited
Loading

  • flipping a bound (either ending or both) arrow now only flips the arrowheads
  • flipping unbound arrow (or when other types are selected alongside) does a regular flip

@vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Sep 19, 2024 0:12am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Sep 19, 2024 0:12am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Sep 19, 2024 0:12am
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 0:12am

@dwelle dwelle requested a review from mtolmacs September 19, 2024 11:34
@github-actions
Copy link

github-actions bot commented Sep 19, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.84% (🎯 66%) 63035 / 94305
🟢 Statements 66.84% (🎯 66%) 63035 / 94305
🟢 Functions 63.87% (🎯 63%) 1876 / 2937
🟢 Branches 80.17% (🎯 70%) 7752 / 9669
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/actions/actionFlip.ts 100% 96.15% 100% 100%
Generated in workflow #3335

@dwelle dwelle merged commit 8ca4cf3 into master Sep 19, 2024
7 checks passed
@dwelle dwelle deleted the dwelle/flip-arrowheads branch September 19, 2024 13:46
Mrazator pushed a commit to dwelle/excalidraw that referenced this pull request Sep 20, 2024
@dwelle @mtolmacs @Mrazator
feat: flip arrowheads if only arrow(s) selected (excalidraw#8525)
8eb60d1 
Co-authored-by: Mark Tolmacs <mark@lazycat.hu>
@sentry
Copy link

sentry bot commented Sep 21, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: function is not iterable (cannot read property Symbol(Symbol.iterator)) pointRotateRads(packages/math/point) View Issue

Did you find this useful? React with a 👍 or 👎

@mtolmacs
Copy link
Collaborator

mtolmacs commented Sep 21, 2024

This was a variable / function name conflict, which was fixed in a sepatate PR.

Mrazator pushed a commit that referenced this pull request Sep 24, 2024
@dwelle @mtolmacs @Mrazator
feat: flip arrowheads if only arrow(s) selected (#8525)
45173c6 
Co-authored-by: Mark Tolmacs <mark@lazycat.hu>
Mrazator pushed a commit to dwelle/excalidraw that referenced this pull request Sep 25, 2024
@dwelle @mtolmacs @Mrazator
feat: flip arrowheads if only arrow(s) selected (excalidraw#8525)
010d46f 
Co-authored-by: Mark Tolmacs <mark@lazycat.hu>
clarencechaan pushed a commit to clarencechaan/excalidraw that referenced this pull request Oct 3, 2024
@dwelle @mtolmacs @clarencechaan
feat: flip arrowheads if only arrow(s) selected (excalidraw#8525)
6590f97 
Co-authored-by: Mark Tolmacs <mark@lazycat.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtolmacs mtolmacs mtolmacs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwelle @mtolmacs