Skip to content

fix: svg and png frame clipping cases #8515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: svg and png frame clipping cases #8515

merged 2 commits into from
Sep 17, 2024

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Sep 17, 2024 •
edited
Loading

  1. When exporting a single frame to PNG, we're effectively exporting with 0 padding, so we shouldn't clip content as it would clip the edges since the frames have a radius.

before:

image

after:

image

  1. When exporting to SVG, we were previously not adding radius at all, so we're doing that now in non-single-frame-export cases

@vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Sep 17, 2024 8:43pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Sep 17, 2024 8:43pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Sep 17, 2024 8:43pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 8:43pm

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.7% (🎯 66%) 62857 / 94231
🟢 Statements 66.7% (🎯 66%) 62857 / 94231
🟢 Functions 63.86% (🎯 63%) 1875 / 2936
🟢 Branches 79.9% (🎯 70%) 7675 / 9605
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/scene/export.ts 87.64% 83.09% 83.33% 87.64% 50-75, 98, 147-148, 172-176, 321-322, 412-416, 437-446, 476-478, 486-491, 494-496
Generated in workflow #3317

@dwelle dwelle changed the title fix: do not clip when exporting single frame to PNG fix: svg and png frame clipping cases Sep 17, 2024
@dwelle dwelle merged commit 44a1c8d into master Sep 17, 2024
@dwelle dwelle deleted the dwelle/fix-export-frame-clip branch September 17, 2024 22:20
zsviczian added a commit to zsviczian/excalidraw that referenced this pull request Sep 18, 2024
@zsviczian
Merge pull request #257 from excalidraw/master
6ecb1fe 
fix: svg and png frame clipping cases (excalidraw#8515)
Mrazator pushed a commit to dwelle/excalidraw that referenced this pull request Sep 20, 2024
@dwelle @Mrazator
fix: svg and png frame clipping cases (excalidraw#8515)
ec0c982
Mrazator pushed a commit that referenced this pull request Sep 24, 2024
@dwelle @Mrazator
fix: svg and png frame clipping cases (#8515)
1338409
Mrazator pushed a commit to dwelle/excalidraw that referenced this pull request Sep 25, 2024
@dwelle @Mrazator
fix: svg and png frame clipping cases (excalidraw#8515)
1ffa273
clarencechaan pushed a commit to clarencechaan/excalidraw that referenced this pull request Oct 3, 2024
@dwelle @clarencechaan
fix: svg and png frame clipping cases (excalidraw#8515)
6d06981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dwelle