fix: Linear element complete button disabled #8492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
zsviczian
changed the title
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
Enabling pointer events across the whole UI isn't a good idea as it'll allow people to click buttons which will put you in an undefined state. Let's add selectors on the "finalize buttons" (mobile + non-mobile view) and force-enable |
Amazing. This turns out to be a simpler and much cleaner solution! |
dwelle
approved these changes
Sep 12, 2024
Mrazator
pushed a commit
to dwelle/excalidraw
that referenced
this pull request
Sep 20, 2024
Mrazator
pushed a commit
that referenced
this pull request
Sep 24, 2024
Mrazator
pushed a commit
to dwelle/excalidraw
that referenced
this pull request
Sep 25, 2024
clarencechaan
pushed a commit
to clarencechaan/excalidraw
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2006
If you touch the screen with two fingers when creating a new linear element you can create a multipoint line by adding additional points. There is a complete edit button, but this is disabled during editing of the new element. On a mobile device there is simply no way to exit the line edit mode (unless by chance you find the beginning of the line and you are able to close the loop (if you know about this trick and if you can tap precisely enough). This can be an extremely frustrating UX experience when it happens.