Skip to content

fix: improve canvas search scroll behavior further #8491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix: improve canvas search scroll behavior further #8491

merged 3 commits into from
Sep 11, 2024

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Sep 10, 2024 •
edited
Loading

Still not quite happy with the behavior, but I think it's on the right track. Feel free to tweak further.

search for test in https://excalidraw-git-dwelle-further-search-zooming-tweaks-excalidraw.vercel.app/#json=3byClZnjTF-kNYYeQRYGb,q5f2AP0mKotRZris1S9CrA

@dwelle dwelle requested review from ryan-di and zsviczian September 10, 2024 22:18
@vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Sep 11, 2024 3:24pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Sep 11, 2024 3:24pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Sep 11, 2024 3:24pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:24pm

dwelle
dwelle commented Sep 10, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.68% (🎯 66%) 62801 / 94171
🟢 Statements 66.68% (🎯 66%) 62801 / 94171
🟢 Functions 63.81% (🎯 63%) 1873 / 2935
🟢 Branches 79.9% (🎯 70%) 7664 / 9591
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/types.ts 100% 100% 100% 100%
packages/excalidraw/actions/actionCanvas.tsx 74.28% 70.9% 61.11% 74.28% 49-53, 55-61, 114, 154-155, 195-196, 211-226, 235-236, 244, 303-310, 388-398, 403-405, 414-424, 428-430, 440-448, 451-453, 459-462, 488-514, 526-553
packages/excalidraw/components/App.tsx 71.03% 77.6% 71.13% 71.03% 488-489, 600-609, 709-710, 728-729, 750-810, 813-819, 832-835, 838-914, 917-936, 939-944, 952-962, 964-965, 970-971, 975-977, 991, 998-1260, 1320-1321, 1353-1355, 1362-1407, 1433, 1443, 1450-1453, 1462-1466, 1497-1498, 1576-1586, 1591-1606, 1610-1657, 1753-1758, 1787-1792, 1795-1825, 1833-1858, 1871-1962, 1965-1973, 1976-2035, 2038-2079, 2082-2087, 2124-2125, 2148-2149, 2180-2181, 2185-2186, 2206-2214, 2219-2232, 2238-2239, 2243, 2248-2256, 2258-2266, 2278, 2323-2324, 2346-2347, 2354, 2375-2377, 2437-2439, 2442-2447, 2452-2453, 2493-2501, 2506-2515, 2553-2554, 2646-2647, 2651, 2654-2655, 2663-2666, 2675-2688, 2694-2697, 2700, 2702-2703, 2710-2711, 2717-2718, 2721-2722, 2730-2731, 2734-2735, 2746-2754, 2759-2760, 2811-2812, 2826-2832, 2838-2846, 2850-2858, 2862-2863, 2866-2899, 2902-2914, 2925-2926, 2937-2938, 2955-2959, 2963-2966, 2973-2975, 2993-3000, 3003, 3005-3010, 3014-3016, 3062-3063, 3070-3072, 3074-3097, 3123, 3129, 3185-3186, 3203-3205, 3227-3228, 3234-3238, 3244-3325, 3379, 3383, 3418-3419, 3478, 3488-3506, 3509-3515, 3518-3519, 3525-3541, 3654-3655, 3678-3692, 3697-3708, 3760-3761, 3833-3843, 3879, 4006-4007, 4009-4016, 4050-4054, 4056-4057, 4059-4062, 4087-4088, 4110-4120, 4130-4132, 4134, 4215-4218, 4240-4248, 4252-4254, 4264-4265, 4267-4287, 4294-4317, 4320-4326, 4343-4346, 4358-4365, 4461-4465, 4469, 4474-4475, 4480-4484, 4517-4518, 4521-4522, 4534-4538, 4543-4544, 4550-4560, 4565-4592, 4597-4608, 4705-4706, 4790, 4815, 4841-4843, 4910-4911, 4929-4930, 5105-5106, 5109-5110, 5118-5119, 5169-5173, 5227-5234, 5240-5307, 5351, 5408, 5435, 5442-5443, 5456-5459, 5490, 5543-5546, 5549-5553, 5555-5562, 5579-5588, 5591-5592, 5722-5723, 5726, 5728-5733, 5739-5741, 5743, 5752, 5774-5779, 5781-5784, 5788-5789, 5799-5895, 5899-5900, 5915-5916, 5952-5958, 5985-5986, 5998-5999, 6027, 6029-6056, 6063-6064, 6086-6087, 6106, 6108-6151, 6156-6157, 6159-6160, 6176-6177, 6183-6184, 6188-6191, 6194-6195, 6209-6235, 6243-6244, 6248-6251, 6253-6257, 6275-6279, 6326-6331, 6333-6335, 6351, 6353-6366, 6391-6394, 6449, 6466-6467, 6469-6492, 6507-6508, 6622-6650, 6756-6757, 6777-6778, 6872, 6878-6879, 6902-6921, 6936, 7084-7122, 7126-7176, 7191, 7200, 7234-7240, 7264-7266, 7432-7435, 7457-7487, 7500, 7502-7510, 7524, 7526-7534, 7541-7544, 7552-7557, 7584-7585, 7590-7592, 7595-7596, 7619-7620, 7651-7652, 7735-7736, 7783-7796, 7873-7876, 7902-7903, 7959, 7982-7988, 7999-8018, 8046-8052, 8084, 8126, 8132, 8147-8154, 8157-8164, 8214, 8292-8293, 8314-8316, 8319, 8333-8357, 8466-8479, 8502-8526, 8535-8574, 8587-8588, 8597-8604, 8622-8629, 8683-8707, 8709-8710, 8784-8785, 8792, 8794-8830, 8859, 8918, 8952-8954, 8979-8984, 8986-8987, 8992-8994, 8997-9017, 9031-9032, 9038-9047, 9052, 9056-9060, 9069-9073, 9076-9081, 9085-9092, 9122, 9124-9128, 9130-9140, 9156-9158, 9169-9177, 9181-9225, 9228-9299, 9307, 9325-9332, 9334-9350, 9365-9387, 9406-9408, 9454-9455, 9566-9570, 9572-9588, 9590-9594, 9606-9607, 9617-9633, 9652-9671, 9673-9674, 9701-9702, 9706-9707, 9717, 9719-9722, 9724-9725, 9765, 9806-9807, 9817, 9859, 9877-9885, 9906-9907, 9939-9942, 10035-10042, 10068-10069, 10112-10183, 10231-10232, 10241-10244, 10249-10250, 10271-10273, 10275-10279, 10317
packages/excalidraw/components/SearchMenu.tsx 90.94% 76.84% 75% 90.94% 118-119, 127-138, 191, 199-204, 242-243, 245-251, 259-262, 266-269, 283-284, 286-288, 355-356, 363-364, 376, 489, 623-635, 671-673
packages/excalidraw/element/newElement.ts 91.98% 90.17% 85.71% 91.98% 143-148, 151-158, 178-192, 210, 382, 384-387, 404-405, 514, 520-521, 536-553, 590-591
packages/excalidraw/element/sizeHelpers.ts 64.5% 72.41% 71.42% 64.5% 110, 123-124, 129-166, 169-201, 219-222, 225-228
packages/excalidraw/scene/scroll.ts 94.5% 92.85% 100% 94.5% 66-70
packages/math/utils.ts 100% 100% 80% 100%
Generated in workflow #3285

@dwelle dwelle mentioned this pull request Sep 10, 2024
Closed
@zsviczian
Copy link
Collaborator

zsviczian commented Sep 11, 2024

I think zooming is now pretty robust! The only thing I'd consider when setting the zoom and position - especially in case of large text like XXL in the below example, is how the search window on the right should maybe be deducted from the visible area.

2024-09-11.07-47-50.mp4

@dwelle
Copy link
Member Author

dwelle commented Sep 11, 2024

I think zooming is now pretty robust! The only thing I'd consider when setting the zoom and position - especially in case of large text like XXL in the below example, is how the search window on the right should maybe be deducted from the visible area.

Done. c289c80 (#8491)

@zsviczian
Copy link
Collaborator

zsviczian commented Sep 11, 2024 •
edited
Loading

Did a bit of testing. I can confirm zooming works very nice now. I think this is good to go!

2024-09-11.17-32-47.mp4

@dwelle dwelle merged commit fd39712 into master Sep 11, 2024
@dwelle dwelle deleted the dwelle/further-search-zooming-tweaks branch September 11, 2024 16:01
clarencechaan pushed a commit to clarencechaan/excalidraw that referenced this pull request Oct 3, 2024
@dwelle @clarencechaan
fix: improve canvas search scroll behavior further (excalidraw#8491)
20212ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zsviczian zsviczian Awaiting requested review from zsviczian

@ryan-di ryan-di Awaiting requested review from ryan-di

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dwelle @zsviczian @ryan-di