fix: Buffer dependency #8474
Merged
fix: Buffer dependency #8474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
dwelle
reviewed
Sep 12, 2024
packages/excalidraw/utils.ts
Outdated
| return Buffer.from(base64String, "base64").buffer; | ||
| } | ||
| // Browser environment | ||
| return base64ToArrayBuffer(base64String); |
There was a problem hiding this comment.
can we reuse our byteStringToArrayBuffer() here?
So:
byteStringToArrayBuffer(atob(base64))
Let's also rename the helper to base64ToArrayBuffer to more or less align with our other serde helpers, and put into packages/excalidraw/data/encode.ts
There was a problem hiding this comment.
I did not find byteStringToArrayBuffer...
I've applied the changes
|
Ok. I've implemented the recommended changes. |
|
@zsviczian I've moved the parsing of base64 out of the helper as that helper should already accept base64 string, not url (also, you were already passing a dataURL, not If it looks good, you can merge! |
dwelle
approved these changes
Sep 12, 2024
Mrazator
pushed a commit
to dwelle/excalidraw
that referenced
this pull request
Sep 20, 2024
* fix Buffer dependency * moved to encode.ts * move base64 parsing out --------- Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
Mrazator
pushed a commit
that referenced
this pull request
Sep 24, 2024
* fix Buffer dependency * moved to encode.ts * move base64 parsing out --------- Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
Mrazator
pushed a commit
to dwelle/excalidraw
that referenced
this pull request
Sep 25, 2024
* fix Buffer dependency * moved to encode.ts * move base64 parsing out --------- Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
clarencechaan
pushed a commit
to clarencechaan/excalidraw
that referenced
this pull request
Oct 3, 2024
* fix Buffer dependency * moved to encode.ts * move base64 parsing out --------- Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses: #8472