Skip to content

fix: View mode wheel zooming does not work #8452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2024
Merged

fix: View mode wheel zooming does not work #8452

merged 2 commits into from
Aug 31, 2024

Conversation

@zsviczian
Copy link
Collaborator

@zsviczian zsviczian commented Aug 31, 2024

Fixes: #8451
Regression #8437

@vercel
Copy link

vercel bot commented Aug 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Aug 31, 2024 8:31am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Aug 31, 2024 8:31am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Aug 31, 2024 8:31am
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 31, 2024 8:31am

@github-actions
Copy link

github-actions bot commented Aug 31, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 65.85% (🎯 70%) 60968 / 92578
🔴 Statements 65.85% (🎯 70%) 60968 / 92578
🔴 Functions 63.16% (🎯 68%) 1847 / 2924
🟢 Branches 79.95% (🎯 70%) 7532 / 9420
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/components/App.tsx 70.89% 77.37% 70.98% 70.89% 483-484, 594-603, 702-703, 721-722, 743-803, 806-812, 825-828, 831-907, 910-929, 932-937, 945-955, 957-958, 963-964, 968-970, 984, 991-1253, 1313-1314, 1346-1348, 1355-1400, 1426, 1436, 1443-1446, 1455-1459, 1489-1490, 1568-1578, 1583-1598, 1602-1649, 1745-1750, 1779-1784, 1787-1817, 1825-1850, 1863-1954, 1957-1965, 1968-2027, 2030-2071, 2074-2079, 2116-2117, 2140-2141, 2172-2173, 2177-2178, 2198-2206, 2211-2224, 2230-2231, 2235, 2240-2248, 2250-2258, 2270, 2312-2313, 2335-2336, 2343, 2416-2418, 2421-2426, 2431-2432, 2472-2480, 2485-2494, 2532-2533, 2625-2626, 2630, 2633-2634, 2642-2645, 2654-2667, 2673-2676, 2679, 2681-2682, 2689-2690, 2696-2697, 2700-2701, 2709-2710, 2713-2714, 2725-2733, 2738-2739, 2790-2791, 2805-2811, 2817-2825, 2829-2837, 2841-2842, 2845-2878, 2881-2893, 2904-2905, 2916-2917, 2934-2938, 2942-2945, 2952-2954, 2972-2979, 2982, 2984-2989, 2993-2995, 3041-3042, 3049-3051, 3053-3076, 3102, 3108, 3164-3165, 3182-3184, 3206-3207, 3213-3216, 3222-3303, 3357, 3361, 3396-3397, 3456, 3466-3484, 3487-3493, 3496-3497, 3503-3519, 3624-3625, 3648-3662, 3667-3686, 3738-3739, 3819-3824, 3855, 3981-3982, 3984-3991, 4025-4029, 4031-4032, 4034-4037, 4062-4063, 4085-4095, 4105-4107, 4109, 4190-4193, 4215-4223, 4227-4229, 4239-4240, 4242-4262, 4269-4292, 4295-4301, 4318-4321, 4333-4340, 4435-4439, 4443, 4448-4449, 4454-4458, 4491-4492, 4495-4496, 4508-4512, 4517-4518, 4524-4534, 4539-4566, 4571-4582, 4679-4680, 4764, 4789, 4815-4817, 4884-4885, 4903-4904, 5079-5080, 5083-5084, 5092-5093, 5143-5147, 5201-5208, 5214-5280, 5324, 5381, 5408, 5415-5416, 5429-5432, 5463, 5515-5518, 5521-5527, 5529-5536, 5553-5562, 5565-5566, 5696-5697, 5700, 5702-5707, 5713-5715, 5717, 5726, 5748-5753, 5755-5758, 5762-5763, 5773-5873, 5877-5878, 5893-5894, 5930-5936, 5963-5964, 5995, 5997-6024, 6031-6032, 6054-6055, 6074, 6076-6119, 6124-6125, 6127-6128, 6144-6145, 6151-6152, 6156-6159, 6162-6163, 6177-6203, 6211-6212, 6216-6219, 6221-6225, 6243-6247, 6294-6299, 6301-6303, 6319, 6321-6334, 6359-6362, 6409, 6426-6427, 6429-6452, 6467-6468, 6582-6610, 6716-6717, 6737-6738, 6832, 6838-6839, 6862-6881, 6896, 7044-7082, 7086-7136, 7151, 7160, 7194-7200, 7226-7228, 7394-7397, 7419-7449, 7462, 7464-7472, 7486, 7488-7496, 7503-7506, 7514-7519, 7546-7547, 7552-7554, 7557-7558, 7583-7584, 7615-7616, 7699-7700, 7747-7760, 7837-7840, 7866-7867, 7923, 7946-7952, 7963-7982, 8010-8016, 8048, 8090, 8096, 8111-8118, 8121-8128, 8178, 8256-8257, 8278-8280, 8283, 8297-8321, 8427-8440, 8463-8487, 8496-8535, 8548-8549, 8558-8565, 8583-8590, 8644-8670, 8672-8673, 8747-8748, 8755, 8757-8793, 8822, 8881, 8915-8917, 8942-8947, 8949-8950, 8955-8957, 8960-8980, 8994-8995, 9001-9010, 9015, 9019-9023, 9032-9036, 9039-9044, 9048-9055, 9085, 9087-9091, 9093-9103, 9119-9121, 9132-9140, 9144-9188, 9191-9262, 9270, 9288-9295, 9297-9313, 9328-9350, 9369-9371, 9417-9418, 9529-9533, 9535-9551, 9553-9557, 9569-9570, 9580-9596, 9615-9634, 9636-9637, 9664-9665, 9669-9670, 9680, 9682-9685, 9687-9688, 9728, 9769-9770, 9780, 9822, 9840-9848, 9869-9870, 9902-9905, 9998-10005, 10031-10032, 10075-10146, 10194-10195, 10204-10207, 10212-10213, 10234-10236, 10238-10242, 10280
Generated in workflow #3216

@dwelle
Copy link
Member

dwelle commented Aug 31, 2024

Thanks Zsolt! I've pushed a fix for preventing mouse-zoom when not over canvas.

@zsviczian zsviczian merged commit 2d1d84a into master Aug 31, 2024
@zsviczian zsviczian deleted the zsviczian-fix-viewmode-zoom branch August 31, 2024 10:06
clarencechaan pushed a commit to clarencechaan/excalidraw that referenced this pull request Oct 3, 2024
@zsviczian @dwelle @clarencechaan
fix: View mode wheel zooming does not work (excalidraw#8452)
de9d5e4 
* Update App.tsx

* fix: prevent zooming browser over DOM

---------

Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: Wheel zoom no longer works in view mode

3 participants

@zsviczian @dwelle