Skip to content

Conversation

@zsviczian
Copy link
Collaborator

fixes: #8385

@vercel
Copy link

vercel bot commented Aug 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Aug 25, 2024 10:43pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Aug 25, 2024 10:43pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Aug 25, 2024 10:43pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2024 10:43pm

@github-actions
Copy link

github-actions bot commented Aug 17, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 66.81% (🎯 70%) 58462 / 87501
🔴 Statements 66.81% (🎯 70%) 58462 / 87501
🟢 Functions 68.43% (🎯 68%) 1739 / 2541
🟢 Branches 80.97% (🎯 70%) 7304 / 9020
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/components/Stats/DragInput.tsx 66.38% 87.5% 55.55% 66.38% 108-110, 200-298, 300-303, 312-322, 336
Generated in workflow #3146

Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zsolt. I've added an additional failsafe for removal of the callbacks in case pointerup doesn't fire.

@dwelle dwelle merged commit b459e5c into master Aug 26, 2024
@dwelle dwelle deleted the zsviczian-fix-context-menu-flashes-up branch August 26, 2024 13:58
shenyih0ng pushed a commit to shenyih0ng/excalidraw that referenced this pull request Aug 27, 2024
excalidraw#8386)

Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
clarencechaan pushed a commit to clarencechaan/excalidraw that referenced this pull request Oct 3, 2024
excalidraw#8386)

Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: The context menu flashes up and not functional after dragging on StatsDragInput in element stats editor

3 participants