Skip to content

fix: object snapping not working #8381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: object snapping not working #8381

merged 1 commit into from
Aug 15, 2024

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Aug 15, 2024

fix #8380

@vercel
Copy link

vercel bot commented Aug 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Aug 15, 2024 4:47pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Aug 15, 2024 4:47pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Aug 15, 2024 4:47pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 15, 2024 4:47pm

@github-actions
Copy link

github-actions bot commented Aug 15, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 66.6% (🎯 70%) 58279 / 87504
🔴 Statements 66.6% (🎯 70%) 58279 / 87504
🟢 Functions 68.29% (🎯 68%) 1734 / 2539
🟢 Branches 80.97% (🎯 70%) 7291 / 9004
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/snapping.ts 28.67% 43.9% 42.3% 28.67% 37-38, 123-124, 136-137, 164, 167-168, 170-173, 176-177, 180-274, 277-294, 297-412, 415-582, 585-602, 605-658, 671, 681-719, 778-780, 783-794, 797-864, 867-881, 884-1080, 1094-1096, 1103-1179, 1192, 1234-1259, 1305-1366, 1369-1370
packages/excalidraw/components/App.tsx 70.35% 77.35% 69.74% 70.35% 485-486, 596-605, 704-705, 723-724, 745-805, 808-814, 827-830, 833-909, 912-931, 934-939, 947-957, 959-960, 965-966, 970-972, 986, 993-1255, 1315-1316, 1348-1350, 1357-1402, 1428, 1438, 1445-1448, 1457-1461, 1493-1494, 1578-1588, 1593-1608, 1612-1659, 1734-1739, 1768-1773, 1776-1806, 1814-1839, 1842-1851, 1854-1966, 1969-1977, 1986-1999, 2002-2028, 2031-2102, 2105-2146, 2149-2154, 2191-2192, 2214-2215, 2246-2247, 2251-2252, 2272-2280, 2285-2298, 2304-2305, 2309, 2314-2322, 2324-2332, 2344, 2386-2387, 2409-2410, 2417, 2490-2492, 2495-2500, 2505-2506, 2546-2554, 2559-2568, 2606-2607, 2694-2695, 2699, 2702-2703, 2711-2714, 2723-2736, 2742-2745, 2748, 2750-2751, 2758-2759, 2765-2766, 2769-2770, 2778-2779, 2782-2783, 2794-2802, 2807-2808, 2859-2860, 2874-2880, 2886-2894, 2898-2906, 2910-2911, 2914-2947, 2950-2962, 2973-2974, 2985-2986, 3003-3007, 3011-3014, 3021-3023, 3041-3048, 3051, 3053-3058, 3062-3064, 3110-3111, 3118-3120, 3122-3145, 3171, 3177, 3233-3234, 3251-3253, 3275-3276, 3282-3285, 3291-3372, 3426, 3430, 3465-3466, 3525, 3535-3553, 3556-3562, 3565-3566, 3572-3588, 3693-3694, 3717-3731, 3736-3755, 3807-3808, 3888-3893, 3924, 4050-4051, 4053-4060, 4094-4098, 4100-4101, 4103-4106, 4131-4132, 4150-4152, 4154-4156, 4158, 4239-4242, 4264-4272, 4276-4278, 4288-4289, 4291-4311, 4318-4341, 4344-4350, 4367-4370, 4376-4379, 4389-4396, 4491-4495, 4499, 4504-4505, 4510-4514, 4547-4548, 4551-4552, 4564-4568, 4573-4574, 4580-4590, 4595-4622, 4627-4638, 4735-4736, 4820, 4845, 4871-4873, 4940-4941, 4959-4960, 5135-5136, 5139-5140, 5148-5149, 5199-5203, 5257-5264, 5270-5336, 5380, 5437, 5464, 5471-5472, 5485-5488, 5519, 5567-5570, 5573-5579, 5581-5584, 5601-5610, 5613-5614, 5734-5735, 5738, 5740-5745, 5751-5753, 5755, 5764, 5786-5791, 5793-5796, 5800-5801, 5811-5911, 5915-5916, 5931-5932, 5968-5974, 6001-6002, 6033, 6035-6062, 6069-6070, 6092-6093, 6112, 6114-6157, 6162-6163, 6165-6166, 6182-6183, 6189-6190, 6194-6197, 6200-6201, 6215-6242, 6250-6251, 6255-6258, 6260-6264, 6282-6286, 6333-6338, 6340-6342, 6358, 6360-6373, 6398-6401, 6445, 6462-6463, 6465-6488, 6503-6504, 6618-6646, 6752-6753, 6773-6774, 6868, 6874-6875, 6898-6917, 6932, 7061, 7083-7121, 7125-7175, 7190, 7199, 7233-7239, 7265-7267, 7434-7437, 7459-7489, 7502, 7504-7512, 7526, 7528-7536, 7543-7546, 7554-7559, 7586-7587, 7592-7594, 7597-7598, 7623-7624, 7655-7656, 7739-7740, 7787-7800, 7877-7880, 7906-7907, 7963, 7978-7984, 7991-8005, 8029-8035, 8067, 8109, 8115, 8130-8137, 8140-8147, 8203, 8281-8282, 8303-8305, 8308, 8322-8346, 8450-8463, 8484-8508, 8517-8556, 8569-8570, 8579-8586, 8604-8611, 8665-8691, 8693-8694, 8768-8769, 8776, 8778-8814, 8843, 8902, 8936-8938, 8963-8968, 8970-8971, 8976-8978, 8981-9001, 9015-9016, 9022-9031, 9036, 9040-9044, 9053-9057, 9060-9065, 9069-9076, 9106, 9108-9112, 9114-9124, 9140-9142, 9153-9161, 9165-9209, 9212-9283, 9291, 9309-9316, 9318-9334, 9349-9371, 9390-9392, 9438-9439, 9555-9559, 9561-9577, 9579-9583, 9595-9596, 9606-9622, 9641-9660, 9662-9663, 9690-9691, 9695-9696, 9706, 9708-9711, 9713-9714, 9754, 9793-9794, 9804, 9846, 9859-9867, 9888-9889, 9921-9924, 10017-10024, 10050-10051, 10094-10148, 10196-10197, 10206-10209, 10214-10215, 10236-10238, 10240-10244, 10282
packages/excalidraw/components/HintViewer.tsx 93.78% 92% 100% 93.78% 38-39, 59-60, 63-64, 105-106, 138-140
packages/excalidraw/components/Stats/index.tsx 92.87% 88.88% 60% 92.87% 178-185, 203-213, 233-241
Generated in workflow #3084

@dwelle dwelle merged commit fb4bb29 into master Aug 15, 2024
@dwelle dwelle deleted the dwelle/fix-snapping branch August 15, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hold Ctrl to snap if object-snapping and grid are disabled

2 participants

@dwelle