Skip to content

feat: improve zoom-to-content when creating flowchart #8368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2024
Merged

feat: improve zoom-to-content when creating flowchart #8368

merged 2 commits into from
Aug 12, 2024

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Aug 12, 2024 •
edited
Loading

Not fully tested and quite sure not fully correct, but there's no time. We live or we die. We all serve the Omnissiah!

@vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Aug 12, 2024 6:37pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Aug 12, 2024 6:37pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Aug 12, 2024 6:37pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 6:37pm

@github-actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 66.6% (🎯 70%) 58141 / 87295
🔴 Statements 66.6% (🎯 70%) 58141 / 87295
🟢 Functions 68.24% (🎯 68%) 1728 / 2532
🟢 Branches 80.97% (🎯 70%) 7277 / 8987
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/actions/actionCanvas.tsx 70.62% 65.95% 61.11% 70.62% 49-53, 55-61, 112, 152-153, 193-194, 209-224, 233-234, 242, 288-315, 382-391, 396-398, 407-417, 421-423, 433-440, 443-445, 451-454, 480-506, 518-545
packages/excalidraw/components/App.tsx 70.33% 77.33% 69.58% 70.33% 484-485, 595-604, 703-704, 722-723, 744-804, 807-813, 816-819, 822-898, 901-920, 923-928, 936-946, 948-949, 954-955, 959-961, 975, 982-1244, 1304-1305, 1337-1339, 1346-1391, 1417, 1427, 1434-1437, 1446-1450, 1482-1483, 1567-1577, 1582-1597, 1601-1648, 1723-1728, 1757-1762, 1765-1795, 1803-1828, 1831-1840, 1843-1955, 1958-1966, 1975-1988, 1991-2017, 2020-2091, 2094-2135, 2138-2143, 2181-2182, 2208-2209, 2241-2242, 2246-2247, 2267-2275, 2280-2293, 2299-2300, 2304, 2309-2317, 2319-2327, 2339, 2381-2382, 2404-2405, 2412, 2485-2487, 2490-2495, 2500-2501, 2541-2549, 2554-2563, 2601-2602, 2689-2690, 2694, 2697-2698, 2706-2709, 2718-2731, 2737-2740, 2743, 2745-2746, 2753-2754, 2760-2761, 2764-2765, 2773-2774, 2777-2778, 2781-2784, 2795-2803, 2808-2809, 2860-2861, 2875-2881, 2887-2895, 2899-2907, 2911-2912, 2915-2948, 2951-2963, 2974-2975, 2986-2987, 3004-3008, 3012-3015, 3022-3024, 3042-3049, 3052, 3054-3059, 3063-3065, 3111-3112, 3119-3121, 3123-3146, 3172, 3178, 3234-3235, 3252-3254, 3276-3277, 3283-3286, 3292-3373, 3427, 3431, 3466-3467, 3526, 3536-3554, 3557-3563, 3566-3567, 3573-3586, 3691-3692, 3715-3729, 3734-3753, 3805-3806, 3886-3891, 3922, 4048-4049, 4051-4058, 4092-4096, 4098-4099, 4101-4104, 4129-4130, 4148-4150, 4152-4154, 4156, 4237-4240, 4262-4270, 4274-4276, 4286-4287, 4289-4309, 4316-4339, 4342-4348, 4365-4368, 4374-4377, 4387-4394, 4489-4493, 4497, 4502-4503, 4508-4512, 4545-4546, 4549-4550, 4562-4566, 4571-4572, 4578-4588, 4593-4620, 4625-4636, 4733-4734, 4818, 4843, 4869-4871, 4938-4939, 4957-4958, 5133-5134, 5137-5138, 5146-5147, 5197-5201, 5255-5262, 5268-5334, 5378, 5435, 5462, 5469-5470, 5483-5486, 5517, 5565-5568, 5571-5577, 5579-5582, 5599-5608, 5611-5612, 5732-5733, 5736, 5738-5743, 5749-5751, 5753, 5762, 5784-5789, 5791-5794, 5798-5799, 5809-5909, 5913-5914, 5929-5930, 5966-5972, 5999-6000, 6031, 6033-6060, 6067-6068, 6090-6091, 6110, 6112-6155, 6160-6161, 6163-6164, 6180-6181, 6187-6188, 6192-6195, 6198-6199, 6213-6240, 6248-6249, 6253-6256, 6258-6262, 6280-6284, 6331-6336, 6338-6340, 6356, 6358-6371, 6396-6399, 6443, 6460-6461, 6463-6486, 6501-6502, 6616-6644, 6750-6751, 6771-6772, 6866, 6872-6873, 6896-6915, 6930, 7059, 7081-7119, 7123-7173, 7188, 7197, 7231-7237, 7263-7265, 7432-7435, 7457-7487, 7500, 7502-7510, 7524, 7526-7534, 7541-7544, 7552-7557, 7584-7585, 7590-7592, 7595-7596, 7621-7622, 7653-7654, 7737-7738, 7785-7798, 7875-7878, 7904-7905, 7961, 7976-7982, 7989-8003, 8027-8033, 8065, 8107, 8113, 8128-8135, 8138-8145, 8201, 8279-8280, 8301-8303, 8306, 8320-8344, 8448-8461, 8482-8506, 8515-8554, 8567-8568, 8577-8584, 8602-8609, 8663-8689, 8691-8692, 8766-8767, 8774, 8776-8812, 8841, 8900, 8934-8936, 8961-8966, 8968-8969, 8974-8976, 8979-8999, 9013-9014, 9020-9029, 9034, 9038-9042, 9051-9055, 9058-9063, 9067-9074, 9104, 9106-9110, 9112-9122, 9138-9140, 9151-9159, 9163-9207, 9210-9281, 9289, 9307-9314, 9316-9332, 9347-9369, 9388-9390, 9436-9437, 9553-9557, 9559-9575, 9577-9581, 9593-9594, 9604-9620, 9639-9658, 9660-9661, 9688-9689, 9693-9694, 9704, 9706-9709, 9711-9712, 9752, 9791-9792, 9802, 9844, 9857-9865, 9886-9887, 9919-9922, 10015-10022, 10048-10049, 10092-10146, 10194-10195, 10204-10207, 10212-10213, 10234-10236, 10238-10242, 10280
packages/excalidraw/element/bounds.ts 85.2% 82.83% 93.33% 85.2% 166, 210-237, 253-259, 262-272, 292-300, 323-324, 456-459, 503, 505, 513, 517, 529-530, 582, 587, 606-608, 617-647, 663-664, 691-703, 767-777, 810-813, 857-858
packages/excalidraw/element/sizeHelpers.ts 65.25% 84% 71.42% 65.25% 115, 128-129, 134-171, 174-206, 224-227, 230-233
Generated in workflow #3069

@dwelle dwelle merged commit 4320a3c into master Aug 12, 2024
@dwelle dwelle deleted the dwelle/improve-flowchart-zooming branch August 12, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dwelle