Skip to content

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Aug 9, 2024

we were preventing event due to flowchart keybindings even when inside inputs (e.g. wysiwyg)

@vercel
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Aug 9, 2024 2:36pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Aug 9, 2024 2:36pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Aug 9, 2024 2:36pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 2:36pm

@github-actions
Copy link

github-actions bot commented Aug 9, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 66.51% (🎯 70%) 57889 / 87025
🔴 Statements 66.51% (🎯 70%) 57889 / 87025
🟢 Functions 68.13% (🎯 68%) 1721 / 2526
🟢 Branches 81.05% (🎯 70%) 7257 / 8953
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/components/App.tsx 70.2% 77.54% 69.43% 70.2% 483-484, 594-603, 702-703, 721-722, 743-803, 806-812, 815-818, 821-897, 900-919, 922-927, 935-945, 947-948, 953-954, 958-960, 974, 981-1243, 1303-1304, 1336-1338, 1345-1390, 1416, 1426, 1433-1436, 1445-1449, 1481-1482, 1566-1576, 1581-1596, 1600-1647, 1722-1727, 1756-1761, 1764-1794, 1802-1827, 1830-1839, 1842-1954, 1957-1965, 1974-1987, 1990-2016, 2019-2090, 2093-2134, 2137-2142, 2180-2181, 2207-2208, 2240-2241, 2245-2246, 2266-2274, 2279-2292, 2298-2299, 2303, 2308-2316, 2318-2326, 2338, 2380-2381, 2403-2404, 2411, 2484-2486, 2489-2494, 2499-2500, 2540-2548, 2553-2562, 2600-2601, 2688-2689, 2693, 2696-2697, 2705-2708, 2717-2730, 2736-2739, 2742, 2744-2745, 2752-2753, 2759-2760, 2763-2764, 2772-2773, 2776-2777, 2780-2783, 2794-2802, 2807-2808, 2859-2860, 2874-2880, 2886-2894, 2898-2906, 2910-2911, 2914-2947, 2950-2962, 2973-2974, 2985-2986, 3003-3007, 3011-3014, 3021-3023, 3041-3048, 3051, 3053-3058, 3062-3064, 3110-3111, 3118-3120, 3122-3145, 3171, 3177, 3233-3234, 3251-3253, 3275-3276, 3282-3285, 3291-3372, 3426, 3430, 3465-3466, 3525, 3535-3553, 3556-3562, 3565-3566, 3572-3585, 3690-3691, 3714-3728, 3733-3752, 3804-3805, 3884, 3984-3985, 3987-3994, 4028-4032, 4034-4035, 4037-4040, 4065-4066, 4084-4086, 4088-4090, 4092, 4173-4176, 4198-4206, 4210-4212, 4222-4223, 4225-4245, 4252-4275, 4278-4284, 4301-4304, 4310-4313, 4323-4330, 4424-4428, 4432, 4437-4438, 4443-4447, 4480-4481, 4484-4485, 4497-4501, 4506-4507, 4513-4523, 4528-4555, 4560-4571, 4668-4669, 4753, 4778, 4804-4806, 4873-4874, 4892-4893, 5068-5069, 5072-5073, 5081-5082, 5132-5136, 5190-5197, 5203-5269, 5313, 5370, 5397, 5404-5405, 5418-5421, 5452, 5500-5503, 5506-5512, 5514-5517, 5534-5543, 5546-5547, 5667-5668, 5671, 5673-5678, 5684-5686, 5688, 5697, 5719-5724, 5726-5729, 5733-5734, 5744-5844, 5848-5849, 5864-5865, 5901-5907, 5934-5935, 5966, 5968-5995, 6002-6003, 6025-6026, 6045, 6047-6090, 6095-6096, 6098-6099, 6115-6116, 6122-6123, 6127-6130, 6133-6134, 6148-6175, 6183-6184, 6188-6191, 6193-6197, 6215-6219, 6266-6271, 6273-6275, 6291, 6293-6306, 6331-6334, 6378, 6395-6396, 6398-6421, 6436-6437, 6551-6579, 6685-6686, 6706-6707, 6801, 6807-6808, 6831-6850, 6865, 6994, 7016-7054, 7058-7108, 7123, 7132, 7166-7172, 7198-7200, 7367-7370, 7392-7422, 7435, 7437-7445, 7459, 7461-7469, 7476-7479, 7487-7492, 7519-7520, 7525-7527, 7530-7531, 7556-7557, 7588-7589, 7672-7673, 7720-7733, 7810-7813, 7839-7840, 7896, 7911-7917, 7924-7938, 7962-7968, 8000, 8042, 8048, 8063-8070, 8073-8080, 8136, 8214-8215, 8236-8238, 8241, 8255-8279, 8383-8396, 8417-8441, 8450-8489, 8502-8503, 8512-8519, 8537-8544, 8598-8624, 8626-8627, 8701-8702, 8709, 8711-8747, 8776, 8835, 8869-8871, 8896-8901, 8903-8904, 8909-8911, 8914-8934, 8948-8949, 8955-8964, 8969, 8973-8977, 8986-8990, 8993-8998, 9002-9009, 9039, 9041-9045, 9047-9057, 9073-9075, 9086-9094, 9098-9142, 9145-9216, 9224, 9242-9249, 9251-9267, 9282-9304, 9323-9325, 9371-9372, 9488-9492, 9494-9510, 9512-9516, 9528-9529, 9539-9555, 9574-9593, 9595-9596, 9623-9624, 9628-9629, 9639, 9641-9644, 9646-9647, 9687, 9726-9727, 9737, 9779, 9792-9800, 9821-9822, 9854-9857, 9950-9957, 9983-9984, 10027-10081, 10129-10130, 10139-10142, 10147-10148, 10169-10171, 10173-10177, 10215
Generated in workflow #3036

@dwelle dwelle merged commit 87a9430 into master Aug 9, 2024
@dwelle dwelle deleted the dwelle/disable-flowchart-bindings-inside-inputs branch August 9, 2024 16:44
@sentry
Copy link

sentry bot commented Aug 22, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: not an ExcalidrawFrameElement invariant(packages/excalidraw/utils) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants