Skip to content

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Aug 5, 2024

  • rm:build - removes build/dist folders from excalidraw-app and packages/*
  • rm:node_modules - removes node_modules from excalidraw-app and packages/*
  • clean-install - runs rm:node_modules & yarn

skips docs, examples etc.

Supporting non-bash compatible enviros was a non-goal.

@dwelle dwelle requested review from Mrazator and ad1992 August 5, 2024 08:01
@vercel
Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Aug 5, 2024 9:30pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Aug 5, 2024 9:30pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Aug 5, 2024 9:30pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 9:30pm

@github-actions
Copy link

github-actions bot commented Aug 5, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 66.11% (🎯 70%) 56840 / 85974
🔴 Statements 66.11% (🎯 70%) 56840 / 85974
🔴 Functions 67.79% (🎯 68%) 1699 / 2506
🟢 Branches 80.42% (🎯 70%) 7008 / 8714
File CoverageNo changed files found.
Generated in workflow #2981

Copy link
Member

@Mrazator Mrazator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also encourage cleaning compiled js in examples, due to eslint being stuck otherwise. Though it should ignore such files in the first place.

@dwelle
Copy link
Member Author

dwelle commented Aug 5, 2024

Would also encourage cleaning compiled js in examples, due to eslint being stuck otherwise. Though it should ignore such files in the first place.

yeah I have diff for the eslint thing, but we can remove build folders everywhere for sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants