Skip to content

feat: Orthogonal (elbow) arrows for diagramming #8299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 205 commits into from
Aug 1, 2024
Merged

feat: Orthogonal (elbow) arrows for diagramming #8299

merged 205 commits into from
Aug 1, 2024

Conversation

@mtolmacs
Copy link
Collaborator

@mtolmacs mtolmacs commented Jul 30, 2024

elbow
elbow2

mtolmacs added 30 commits June 10, 2024 18:58
@mtolmacs
Action: Elbow Arrow button
99f9593 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Basic visual debugging
6a068d2 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
getElementShape is factored out of App.tsx
fb214bc 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Fix for getElementShape crash
2fee25b
@mtolmacs
Scene now routed to the LinearElementEditor update methods
b5318dc 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Ratio based binding point instead of focus & gap for elbow arrows
0bcd009 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Routing grid development #1
c300021 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Restore elbow arrow state on reload
2c6b1f5 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Developing routing #2: Working grid creation
d3ca247 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Grid development #3
39c74f9 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Binary heap implementation
431baf0
@mtolmacs
Arrow routing #1
e39f25a 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Dongle rendering
2cbf4f6 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Routing fixes
9a54e05 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Path generation fix
7b255cc 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Routing
054ef5b 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Routing fixes
b5c0f1d 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Rename to mutateElbowArrow
2daf2ab 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Mutate real arrow points
13683af 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Binding ratio exchanged for fixedPoint
864f6b7 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Jumping on cornders fixed (5px snapping issue)
08e646c 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Dynamic bbox
6e76e95 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Gap for side routing
a6eba9f 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Attempt at more stable routing
e1db8ec 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Janky arrow fixes
4aee381 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
One set of routing fixes
ac03bf9 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Routing variation #3
4209b3c 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Parameter update
e93f37c 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Bounding box calc update
1f12b5c 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
More routing
233e44f 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Fix elbow arrow hidden point highlights
eac5010 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Reverting fixedPoint safety net
fcb473c 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
mtolmacs added 2 commits August 1, 2024 16:50
@mtolmacs
Fix test for rotation elbow arrow
2fffc06 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Remove debug
7246a65 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@dwelle
Copy link
Member

dwelle commented Aug 1, 2024

Alright, let's do this! 🚀 ❤️

@dwelle dwelle merged commit 15e0197 into master Aug 1, 2024
@dwelle dwelle deleted the feat/connector branch August 1, 2024 16:39
@zsviczian zsviczian mentioned this pull request Aug 1, 2024
Closed
@mtolmacs mtolmacs mentioned this pull request Aug 8, 2024
Merged
@zsviczian
Copy link
Collaborator

zsviczian commented Aug 8, 2024

This PR introduced this regression: BUG: line editor, each new point is duplicated when adding points with ALT/OPT drag #8346

@zsviczian zsviczian mentioned this pull request Aug 8, 2024
Closed
@sentry
Copy link

sentry bot commented Aug 12, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading '0') getElementPointsCoords(packages/excalidraw/elem... View Issue
  • ‼️ TypeError: null is not an object (evaluating 'e.pos') astar(packages/excalidraw/element/routing) View Issue

Did you find this useful? React with a 👍 or 👎

@zsviczian zsviczian mentioned this pull request Aug 18, 2024
Closed
@hero101 hero101 mentioned this pull request Apr 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mrazator Mrazator Mrazator left review comments

@dwelle dwelle dwelle approved these changes

Assignees

@mtolmacs mtolmacs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mtolmacs @dwelle @zsviczian @Mrazator