Skip to content

fix: load fonts for exportToCanvas #8298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix: load fonts for exportToCanvas #8298

merged 2 commits into from
Jul 30, 2024

Conversation

@Mrazator
Copy link
Member

@Mrazator Mrazator commented Jul 30, 2024

Closes #8296

@vercel
Copy link

vercel bot commented Jul 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jul 30, 2024 3:22pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jul 30, 2024 3:22pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jul 30, 2024 3:22pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 3:22pm

@Mrazator Mrazator changed the title fix: load fonts for exportToCanvas fix: load fonts for exportToCanvas Jul 30, 2024
@github-actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 65.85% (🎯 70%) 54619 / 82943
🔴 Statements 65.85% (🎯 70%) 54619 / 82943
🔴 Functions 67.29% (🎯 68%) 1632 / 2425
🟢 Branches 80.61% (🎯 70%) 6612 / 8202
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/components/App.tsx 69.5% 76.29% 68.06% 69.5% 470-471, 578-587, 686-687, 705-706, 727-787, 790-796, 799-802, 805-881, 884-903, 906-911, 919-929, 931-932, 937-938, 942-944, 958, 965-1226, 1286-1287, 1298-1299, 1327-1329, 1339-1384, 1410, 1420, 1427-1430, 1439-1443, 1474-1475, 1559-1569, 1574-1589, 1593-1640, 1713-1718, 1747-1752, 1755-1785, 1793-1818, 1821-1830, 1833-1945, 1948-1956, 1965-1978, 1981-2007, 2010-2081, 2084-2125, 2173-2174, 2188-2189, 2221-2222, 2226-2227, 2247-2255, 2260-2273, 2279-2280, 2284, 2289-2297, 2299-2307, 2319, 2361-2362, 2384-2385, 2392, 2465-2467, 2470-2475, 2480-2481, 2521-2529, 2534-2543, 2581-2582, 2669-2670, 2674, 2677-2678, 2686-2689, 2698-2711, 2717-2720, 2723, 2725-2726, 2733-2734, 2740-2741, 2744-2745, 2753-2754, 2757-2758, 2761-2764, 2775-2783, 2788-2789, 2839-2840, 2854-2860, 2866-2874, 2878-2886, 2890-2891, 2894-2927, 2930-2942, 2953-2954, 2965-2966, 2983-2987, 2991-2994, 3001-3003, 3021-3028, 3031, 3033-3038, 3042-3044, 3090-3091, 3098-3100, 3102-3125, 3151, 3157, 3213-3214, 3231-3233, 3255-3256, 3262-3265, 3271-3352, 3406, 3410, 3445-3446, 3505, 3515-3533, 3536-3542, 3545-3546, 3552-3565, 3651-3652, 3654-3655, 3660-3662, 3670-3671, 3694-3708, 3713-3732, 3784-3785, 3864, 3873-3874, 3876-3883, 3898-3902, 3913-3914, 3917-3921, 3923-3924, 3926-3929, 3954-3955, 3964-3966, 3968, 4051-4054, 4076-4078, 4088-4089, 4091-4111, 4118-4141, 4144-4150, 4167-4170, 4176-4179, 4189-4196, 4236-4240, 4244, 4249-4250, 4255-4259, 4292-4293, 4296-4297, 4309-4313, 4318-4319, 4325-4335, 4340-4367, 4372-4383, 4447, 4473-4474, 4558, 4583, 4609-4611, 4678-4679, 4697-4698, 4873-4874, 4877-4878, 4886, 4935-4939, 4993-5000, 5006-5072, 5116, 5168, 5195, 5202-5203, 5212-5215, 5246, 5294-5297, 5300-5306, 5308-5311, 5326-5335, 5338-5339, 5439-5440, 5443, 5445-5450, 5456-5458, 5460, 5469, 5491-5496, 5498-5501, 5505-5506, 5516-5616, 5620-5621, 5636-5637, 5673-5674, 5701-5702, 5735-5762, 5769-5770, 5792-5793, 5812, 5814-5857, 5862-5863, 5865-5866, 5882-5883, 5889-5890, 5894-5897, 5900-5901, 5915-5942, 5950-5951, 5955-5958, 5960-5964, 5982-5986, 6033-6038, 6040-6042, 6058, 6060-6073, 6098-6101, 6145, 6162-6163, 6165-6188, 6203-6204, 6315-6343, 6449-6450, 6470-6471, 6565, 6571-6572, 6595-6614, 6629, 6758, 6780-6818, 6822-6872, 6887, 6896, 6930-6936, 6951-6953, 7095-7098, 7122-7153, 7166, 7168-7176, 7190, 7192-7200, 7207-7210, 7218-7223, 7250-7251, 7256-7258, 7261-7262, 7287-7288, 7319-7320, 7403-7404, 7453-7466, 7532-7535, 7561-7562, 7598-7599, 7612, 7630-7636, 7643-7646, 7669-7675, 7747, 7753, 7768-7775, 7778-7785, 7841, 7918-7919, 7940-7942, 7945, 7959-7983, 8111-8135, 8145-8184, 8197-8198, 8207-8214, 8228-8241, 8254-8261, 8315-8341, 8343-8344, 8418-8419, 8426, 8428-8464, 8493, 8557, 8589-8591, 8616-8621, 8623-8624, 8629-8631, 8634-8654, 8668-8669, 8675-8684, 8689, 8693-8697, 8706-8710, 8713-8718, 8722-8729, 8759, 8761-8765, 8767-8777, 8793-8795, 8806-8814, 8818-8862, 8865-8936, 8944, 8962-8969, 8971-8987, 9002-9024, 9043-9045, 9090-9091, 9205-9209, 9211-9227, 9229-9233, 9245-9246, 9256-9272, 9291-9310, 9312-9313, 9340-9341, 9345-9346, 9356, 9358-9361, 9363-9364, 9404, 9425-9426, 9453, 9456, 9497, 9510-9518, 9535-9536, 9568-9571, 9664-9671, 9697-9698, 9741-9795, 9843-9844, 9853-9856, 9861-9862, 9883-9885, 9887-9891, 9929
packages/excalidraw/components/FontPicker/FontPickerList.tsx 18.28% 100% 100% 18.28% 48-264, 266-267
packages/excalidraw/fonts/index.ts 86.15% 86.66% 93.33% 86.15% 58-64, 70-71, 93-98, 103-121, 172-185, 335
packages/excalidraw/scene/export.ts 86.98% 76.66% 80% 86.98% 53-78, 98-99, 108, 160-161, 185-189, 328-329, 380, 386-391, 394-396, 450-454, 475-484
Generated in workflow #2913

@Mrazator Mrazator force-pushed the mrazator/load-fonts-on-export-canvas branch from 678ba32 to 2da2c41 Compare July 30, 2024 13:04
@Mrazator Mrazator requested a review from dwelle July 30, 2024 13:19
dwelle
dwelle reviewed Jul 30, 2024
View reviewed changes
dwelle
dwelle reviewed Jul 30, 2024
View reviewed changes
dwelle
dwelle reviewed Jul 30, 2024
View reviewed changes
dwelle
dwelle reviewed Jul 30, 2024
View reviewed changes
@Mrazator Mrazator force-pushed the mrazator/load-fonts-on-export-canvas branch from 1d2fbb4 to 314798f Compare July 30, 2024 15:18
@Mrazator Mrazator merged commit 5a0771a into master Jul 30, 2024
@Mrazator Mrazator deleted the mrazator/load-fonts-on-export-canvas branch July 30, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

export to blob does not load new fonts

3 participants

@Mrazator @dwelle