fix: freedraw jittering #8238
Merged
fix: freedraw jittering #8238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Awesome, good catch! ❤️ |
dwelle
approved these changes
Jul 14, 2024
|
Sorry, why is the test failing in master branch, when it passed here and in my local setup? |
Jauhen
pushed a commit
to Jauhen/excalidraw
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8234
The problematic code was introduced in #3512 to fix 'shuffle' bug. (d9af609)
At the time, the code was fine. The commit also had corresponding code in
generateElementCanvas()that generated canvas drawing with floored x and y as base. Which was whyx1 = Math.floor(x1)needed to be used indrawElementFromCanvas(), when copying over the rendered element from that canvas.But in #4357, the
Math.floorcode ingeneratedElementCanvas()was removed, yet it did not remove the matching code fromdrawElementFromCanvas()as well. Which resulted in the freehand drawing being rendered to a slightly wrong position.