Skip to content

feat: upgrade mermaid-to-excalidraw to v1.1.0 #8226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 10, 2024
Merged

feat: upgrade mermaid-to-excalidraw to v1.1.0 #8226

merged 5 commits into from
Jul 10, 2024

Conversation

@ad1992
Copy link
Member

@ad1992 ad1992 commented Jul 10, 2024 •
edited
Loading

changelog in excalidraw/mermaid-to-excalidraw#68

To summarize

  • Now the host can pass a config param to parseMermaidToExcalidraw which earlier only support fontSize.
  • Additonally fontSize is renamed to themeVariables.fontSize and type is changed from number to string to keep in sync with mermaid config.
  • I have removed the config since we already pass default params which are same as passed here.

@vercel
Copy link

vercel bot commented Jul 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jul 10, 2024 3:26pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jul 10, 2024 3:26pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jul 10, 2024 3:26pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 3:26pm

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 66.18% (🎯 70%) 53494 / 80827
🔴 Statements 66.18% (🎯 70%) 53494 / 80827
🔴 Functions 67.32% (🎯 68%) 1613 / 2396
🟢 Branches 80.85% (🎯 70%) 6522 / 8066
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/components/App.tsx 69.73% 76.34% 68.22% 69.73% 472-473, 580-589, 688-689, 707-708, 729-789, 792-798, 801-804, 807-883, 886-905, 908-913, 921-931, 933-934, 939-940, 944-946, 960, 967-1228, 1288-1289, 1300-1301, 1329-1331, 1341-1386, 1412, 1422, 1429-1432, 1441-1445, 1476-1477, 1561-1571, 1576-1591, 1595-1642, 1715-1720, 1749-1754, 1757-1787, 1795-1820, 1823-1832, 1835-1947, 1950-1958, 1967-1980, 1983-2009, 2012-2083, 2086-2127, 2175-2176, 2190-2191, 2223-2224, 2228-2229, 2249-2257, 2262-2275, 2281-2282, 2286, 2291-2299, 2301-2309, 2321, 2362-2363, 2385-2386, 2393, 2462-2464, 2467-2472, 2477-2478, 2518-2526, 2531-2540, 2578-2579, 2666-2667, 2671, 2674-2675, 2683-2686, 2695-2708, 2714-2717, 2720, 2722-2723, 2730-2731, 2737-2738, 2741-2742, 2750-2751, 2754-2755, 2758-2761, 2772-2780, 2785-2786, 2836-2837, 2851-2857, 2863-2871, 2875-2883, 2887-2888, 2891-2924, 2927-2939, 2950-2951, 2962-2963, 2980-2984, 2988-2991, 2998-3000, 3018-3025, 3028, 3030-3035, 3039-3041, 3087-3088, 3095-3097, 3099-3122, 3148, 3154, 3210-3211, 3228-3230, 3252-3253, 3259-3262, 3268-3349, 3403, 3407, 3442-3443, 3502, 3512-3530, 3533-3539, 3542-3543, 3549-3562, 3648-3649, 3651-3652, 3657-3659, 3667-3668, 3691-3705, 3710-3729, 3781-3782, 3861, 3870-3871, 3873-3880, 3895-3899, 3910-3911, 3914-3918, 3920-3921, 3923-3926, 3951-3952, 3961-3963, 3965, 4048-4051, 4073-4075, 4085-4086, 4088-4108, 4111-4117, 4134-4137, 4143-4146, 4156-4163, 4203-4207, 4211, 4216-4217, 4222-4226, 4259-4260, 4263-4264, 4276-4280, 4285-4286, 4292-4302, 4307-4334, 4339-4350, 4414, 4440-4441, 4556, 4581, 4607-4609, 4676-4677, 4695-4696, 4871-4872, 4875-4876, 4884, 4933-4937, 4991-4998, 5004-5070, 5114, 5166, 5193, 5200-5201, 5210-5213, 5244, 5292-5295, 5298-5304, 5306-5309, 5324-5333, 5336-5337, 5437-5438, 5441, 5443-5448, 5454-5456, 5458, 5467, 5489-5494, 5496-5499, 5503-5504, 5514-5614, 5618-5619, 5634-5635, 5671-5672, 5699-5700, 5733-5760, 5767-5768, 5790-5791, 5810, 5812-5855, 5860-5861, 5863-5864, 5880-5881, 5887-5888, 5892-5895, 5898-5899, 5913-5940, 5948-5949, 5953-5956, 5958-5962, 5980-5984, 6031-6036, 6038-6040, 6056, 6058-6071, 6096-6099, 6143, 6160-6161, 6163-6186, 6201-6202, 6313-6341, 6447-6448, 6468-6469, 6563, 6569-6570, 6593-6612, 6627, 6756, 6778-6816, 6820-6870, 6885, 6894, 6928-6934, 6949-6951, 7093-7096, 7120-7151, 7164, 7166-7174, 7188, 7190-7198, 7205-7208, 7216-7221, 7248-7249, 7254-7256, 7259-7260, 7285-7286, 7317-7318, 7401-7402, 7451-7464, 7530-7533, 7559-7560, 7596-7597, 7610, 7628-7634, 7641-7644, 7667-7673, 7745, 7751, 7766-7773, 7776-7783, 7839, 7916-7917, 7938-7940, 7943, 7957-7981, 8109-8133, 8143-8182, 8195-8196, 8205-8212, 8226-8239, 8252-8259, 8313-8339, 8341-8342, 8416-8417, 8424, 8426-8462, 8491, 8555, 8587-8589, 8614-8619, 8621-8622, 8627-8629, 8632-8652, 8666-8667, 8673-8682, 8687, 8691-8695, 8704-8708, 8711-8716, 8720-8727, 8757, 8759-8763, 8765-8775, 8791-8793, 8804-8812, 8816-8860, 8863-8934, 8942, 8960-8967, 8969-8985, 9000-9022, 9041-9043, 9088-9089, 9203-9207, 9209-9225, 9227-9231, 9243-9244, 9254-9270, 9289-9308, 9310-9311, 9338-9339, 9343-9344, 9354, 9356-9359, 9361-9362, 9402, 9423-9424, 9451, 9454, 9495, 9508-9516, 9533-9534, 9566-9569, 9662-9669, 9695-9696, 9739-9793, 9841-9842, 9851-9854, 9859-9860, 9881-9883, 9885-9889, 9927
packages/excalidraw/components/TTDDialog/common.ts 63.35% 80% 50% 63.35% 12-30, 68-70, 82, 106-110, 131-161
Generated in workflow #2779

@ad1992 ad1992 marked this pull request as ready for review July 10, 2024 12:47
@ad1992 ad1992 requested a review from dwelle July 10, 2024 12:48
dwelle
dwelle approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ad1992 ad1992 merged commit d25a7d3 into master Jul 10, 2024
@ad1992 ad1992 deleted the aakansha/upgrade-mermaid-to-excalidraw branch July 10, 2024 15:27
Jauhen pushed a commit to Jauhen/excalidraw that referenced this pull request Nov 7, 2024
@ad1992 @Jauhen
feat: upgrade mermaid-to-excalidraw to v1.1.0 (excalidraw#8226)
2e629d3 
* feat: upgrade mermaid-to-excalidraw to v1.1.0

* fixes

* upgrade and remove config as its redundant

* lint

* upgrade to v1.1.0
@bric3 bric3 mentioned this pull request Mar 12, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ad1992 @dwelle