Skip to content

feat: smarter preferred lang detection #8205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2024
Merged

feat: smarter preferred lang detection #8205

merged 1 commit into from
Jul 4, 2024

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Jul 4, 2024

fix #8202

plus some refactor

@vercel
Copy link

vercel bot commented Jul 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jul 4, 2024 3:52pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jul 4, 2024 3:52pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jul 4, 2024 3:52pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 4, 2024 3:52pm

@dwelle dwelle mentioned this pull request Jul 4, 2024
Closed
@github-actions
Copy link

github-actions bot commented Jul 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 66.19% (🎯 70%) 53510 / 80836
🔴 Statements 66.19% (🎯 70%) 53510 / 80836
🔴 Functions 67.32% (🎯 68%) 1613 / 2396
🟢 Branches 80.84% (🎯 70%) 6522 / 8067
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
excalidraw-app/App.tsx 53.3% 62.74% 18.42% 53.3% 154-158, 164-173, 213-248, 250-272, 275-306, 309-314, 317-318, 344, 375-376, 378-392, 396-399, 403-414, 417-429, 443-465, 473-528, 532-533, 536-545, 568-578, 598-622, 632-669, 672-682, 695-708, 717-723, 740-746, 769-789, 810, 836-842, 851-904, 908-910, 913-917, 926-937, 941-943, 961-965, 981-987, 1006-1007, 1024-1029, 1038-1043, 1063-1068, 1077-1082, 1085-1090, 1100-1108, 1113-1116, 1123-1131
excalidraw-app/app-language/language-detector.ts 96% 40% 100% 96% 14
excalidraw-app/app-language/language-state.ts 100% 100% 100% 100%
excalidraw-app/components/AppMainMenu.tsx 100% 33.33% 0% 100%
Generated in workflow #2762

@dwelle dwelle merged commit 148b895 into master Jul 4, 2024
@dwelle dwelle deleted the dwelle/better-lang-detection branch July 4, 2024 15:55
@DDDDD12138 DDDDD12138 mentioned this pull request Jul 22, 2024
Merged
Jauhen pushed a commit to Jauhen/excalidraw that referenced this pull request Nov 7, 2024
@dwelle @Jauhen
feat: smarter preferred lang detection (excalidraw#8205)
7334aae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Browser language is Chinese, but the default display language is English

2 participants

@dwelle