Skip to content

fix: memory leak - scene.destroy() and window.launchQueue #8198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix: memory leak - scene.destroy() and window.launchQueue #8198

merged 2 commits into from
Jul 2, 2024

Conversation

@zsviczian
Copy link
Collaborator

@zsviczian zsviczian commented Jul 2, 2024

No description provided.

@vercel
Copy link

vercel bot commented Jul 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jul 2, 2024 5:21pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jul 2, 2024 5:21pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jul 2, 2024 5:21pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2024 5:21pm

@github-actions
Copy link

github-actions bot commented Jul 2, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 66.18% (🎯 70%) 53485 / 80814
🔴 Statements 66.18% (🎯 70%) 53485 / 80814
🔴 Functions 67.29% (🎯 68%) 1611 / 2394
🟢 Branches 80.86% (🎯 70%) 6520 / 8063
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/components/App.tsx 69.74% 76.34% 68.22% 69.74% 473-474, 581-590, 689-690, 708-709, 730-790, 793-799, 802-805, 808-884, 887-906, 909-914, 922-932, 934-935, 940-941, 945-947, 961, 968-1229, 1289-1290, 1301-1302, 1330-1332, 1342-1387, 1413, 1423, 1430-1433, 1442-1446, 1477-1478, 1562-1572, 1577-1592, 1596-1643, 1716-1721, 1750-1755, 1758-1788, 1796-1821, 1824-1833, 1836-1948, 1951-1959, 1968-1981, 1984-2010, 2013-2084, 2087-2128, 2176-2177, 2191-2192, 2224-2225, 2229-2230, 2250-2258, 2263-2276, 2282-2283, 2287, 2292-2300, 2302-2310, 2322, 2363-2364, 2386-2387, 2394, 2463-2465, 2468-2473, 2478-2479, 2519-2527, 2532-2541, 2579-2580, 2667-2668, 2672, 2675-2676, 2684-2687, 2696-2709, 2715-2718, 2721, 2723-2724, 2731-2732, 2738-2739, 2742-2743, 2751-2752, 2755-2756, 2759-2762, 2773-2781, 2786-2787, 2837-2838, 2852-2858, 2864-2872, 2876-2884, 2888-2889, 2892-2925, 2928-2940, 2951-2952, 2963-2964, 2981-2985, 2989-2992, 2999-3001, 3019-3026, 3029, 3031-3036, 3040-3042, 3090-3091, 3098-3100, 3102-3125, 3151, 3157, 3213-3214, 3231-3233, 3255-3256, 3262-3265, 3271-3352, 3406, 3410, 3445-3446, 3505, 3515-3533, 3536-3542, 3545-3546, 3552-3565, 3651-3652, 3654-3655, 3660-3662, 3670-3671, 3694-3708, 3713-3732, 3784-3785, 3864, 3873-3874, 3876-3883, 3898-3902, 3913-3914, 3917-3921, 3923-3924, 3926-3929, 3954-3955, 3964-3966, 3968, 4051-4054, 4076-4078, 4088-4089, 4091-4111, 4114-4120, 4137-4140, 4146-4149, 4159-4166, 4206-4210, 4214, 4219-4220, 4225-4229, 4262-4263, 4266-4267, 4279-4283, 4288-4289, 4295-4305, 4310-4337, 4342-4353, 4417, 4443-4444, 4559, 4584, 4610-4612, 4679-4680, 4698-4699, 4874-4875, 4878-4879, 4887, 4936-4940, 4994-5001, 5007-5073, 5117, 5169, 5196, 5203-5204, 5213-5216, 5247, 5295-5298, 5301-5307, 5309-5312, 5327-5336, 5339-5340, 5440-5441, 5444, 5446-5451, 5457-5459, 5461, 5470, 5492-5497, 5499-5502, 5506-5507, 5517-5617, 5621-5622, 5637-5638, 5674-5675, 5702-5703, 5736-5763, 5770-5771, 5793-5794, 5813, 5815-5858, 5863-5864, 5866-5867, 5883-5884, 5890-5891, 5895-5898, 5901-5902, 5916-5943, 5951-5952, 5956-5959, 5961-5965, 5983-5987, 6034-6039, 6041-6043, 6059, 6061-6074, 6099-6102, 6146, 6163-6164, 6166-6189, 6204-6205, 6316-6344, 6450-6451, 6471-6472, 6566, 6572-6573, 6596-6615, 6630, 6759, 6781-6819, 6823-6873, 6888, 6897, 6931-6937, 6952-6954, 7096-7099, 7123-7154, 7167, 7169-7177, 7191, 7193-7201, 7208-7211, 7219-7224, 7251-7252, 7257-7259, 7262-7263, 7288-7289, 7320-7321, 7404-7405, 7454-7467, 7533-7536, 7562-7563, 7599-7600, 7613, 7631-7637, 7644-7647, 7670-7676, 7748, 7754, 7769-7776, 7779-7786, 7842, 7919-7920, 7941-7943, 7946, 7960-7984, 8112-8136, 8146-8185, 8198-8199, 8208-8215, 8229-8242, 8255-8262, 8316-8342, 8344-8345, 8419-8420, 8427, 8429-8465, 8494, 8558, 8590-8592, 8617-8622, 8624-8625, 8630-8632, 8635-8655, 8669-8670, 8676-8685, 8690, 8694-8698, 8707-8711, 8714-8719, 8723-8730, 8760, 8762-8766, 8768-8778, 8794-8796, 8807-8815, 8819-8863, 8866-8937, 8945, 8963-8970, 8972-8988, 9003-9025, 9044-9046, 9091-9092, 9206-9210, 9212-9228, 9230-9234, 9246-9247, 9257-9273, 9292-9311, 9313-9314, 9341-9342, 9346-9347, 9357, 9359-9362, 9364-9365, 9405, 9426-9427, 9454, 9457, 9498, 9511-9519, 9536-9537, 9569-9572, 9665-9672, 9698-9699, 9742-9796, 9844-9845, 9854-9857, 9862-9863, 9884-9886, 9888-9892, 9930
Generated in workflow #2755

dwelle
dwelle approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@dwelle dwelle merged commit 2e1f08c into master Jul 2, 2024
@dwelle dwelle deleted the zsviczian-fix-memroyLeak branch July 2, 2024 20:08
Jauhen pushed a commit to Jauhen/excalidraw that referenced this pull request Nov 7, 2024
@zsviczian @Jauhen
fix: memory leak - scene.destroy() and window.launchQueue (excalidraw…
9f52a72 
…#8198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zsviczian @dwelle