fix: Binding after duplicating is now applied for both the old and duplicate shapes #8185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
dwelle
reviewed
Jun 28, 2024
Comment on lines
763
to
765
| const { boundElements } = sceneElements.filter( | ||
| ({ id }) => id === oldElementId, | ||
| )[0]; |
There was a problem hiding this comment.
let's use find so we don't alloc an array for no reason (will require type assertion !, but once we check for unsafe array access we'd need it anyway)
(edit: perf doesn't matter, but feels cleaner)
dwelle
approved these changes
Jun 28, 2024
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
|
regression: Duplicate bound arrow with only one end bound throws error originating from Throttle Fractional indices #8315 |
Jauhen
pushed a commit
to Jauhen/excalidraw
that referenced
this pull request
Nov 7, 2024
…plicate shapes (excalidraw#8185) Using ALT/OPT + drag to clone does not transfer the bindings (or leaves the duplicates in place of the old one , which are also not bound). Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ALT/OPT + drag to clone does not transfer the bindings (or leaves the duplicates in place of the old one , which are also not bound).
Before
After