Skip to content

fix: repair invalid binding on restore & fix type check #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix: repair invalid binding on restore & fix type check #8133

merged 1 commit into from
Jun 13, 2024

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Jun 13, 2024

fix #8131

@vercel
Copy link

vercel bot commented Jun 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jun 13, 2024 5:30pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jun 13, 2024 5:30pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jun 13, 2024 5:30pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 5:30pm

@dwelle dwelle mentioned this pull request Jun 13, 2024
Closed
@github-actions
Copy link

github-actions bot commented Jun 13, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 66% (🎯 70%) 53119 / 80473
🔴 Statements 66% (🎯 70%) 53119 / 80473
🔴 Functions 67.16% (🎯 68%) 1606 / 2391
🟢 Branches 80.94% (🎯 70%) 6496 / 8025
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/data/restore.ts 88.54% 84.04% 78.57% 88.54% 90-93, 156, 206-208, 238-242, 364, 394-404, 449-450, 459-467, 470-482, 489-498, 507-516, 534-539
packages/excalidraw/element/binding.ts 94.9% 91.21% 98.3% 94.9% 225, 231, 250, 255, 298-299, 506-507, 581, 583-584, 604, 614-616, 712-713, 718-733, 742-749, 761-764, 773-785, 805-806, 1162-1164, 1202-1207, 1253-1254, 1276-1277, 1329-1331, 1506-1507, 1618-1619, 1651-1655
packages/excalidraw/element/typeChecks.ts 88.3% 89.74% 92% 88.3% 191-193, 224, 232-234, 239-241, 243-247, 250-265
Generated in workflow #2642

@dwelle dwelle merged commit 4dc4590 into master Jun 13, 2024
@dwelle dwelle deleted the dwelle/fix-binding branch June 13, 2024 17:42
zsviczian added a commit to zsviczian/excalidraw that referenced this pull request Jun 18, 2024
@zsviczian
Merge pull request #227 from excalidraw/master
452fa1c 
fix: repair invalid binding on restore & fix type check (excalidraw#8133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: App gets stuck with dragging an element

2 participants

@dwelle