Skip to content

fix: wysiwyg blur-submit on mobile #8075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2024
Merged

fix: wysiwyg blur-submit on mobile #8075

merged 2 commits into from
May 28, 2024

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented May 28, 2024

Submitting via blur by touching on canvas on mobile doesn't work.

Though it may be a deeper problem with our canvas mobile pointerdown handling and we should address it on that level.

@vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview May 28, 2024 2:12pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview May 28, 2024 2:12pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview May 28, 2024 2:12pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 2:12pm

@github-actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 65.62% (🎯 70%) 51443 / 78392
🔴 Statements 65.62% (🎯 70%) 51443 / 78392
🔴 Functions 66.68% (🎯 68%) 1567 / 2350
🟢 Branches 80.97% (🎯 70%) 6304 / 7785
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/element/textWysiwyg.tsx 83.77% 79.16% 76.47% 83.77% 63-64, 66-67, 122-123, 310-340, 365-371, 373-375, 379, 486-488, 496-497, 507-508, 518-523, 558-559, 582, 588-616, 633, 635, 638-643, 650-659, 686-689
Generated in workflow #2576

@dwelle dwelle merged commit 08b13f9 into master May 28, 2024
@dwelle dwelle deleted the dwelle/fix-mobile-editor-blur branch May 28, 2024 14:18
@dwelle dwelle mentioned this pull request Jun 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dwelle