Skip to content

fix: remove unused param from drawImagePlaceholder #7991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

fix: remove unused param from drawImagePlaceholder #7991

merged 1 commit into from
May 7, 2024

Conversation

@ad1992
Copy link
Member

@ad1992 ad1992 commented May 7, 2024

No description provided.

@vercel
Copy link

vercel bot commented May 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview May 7, 2024 2:48pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview May 7, 2024 2:48pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview May 7, 2024 2:48pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 2:48pm

@github-actions
Copy link

github-actions bot commented May 7, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 65.5% (🎯 70%) 51037 / 77918
🔴 Statements 65.5% (🎯 70%) 51037 / 77918
🔴 Functions 66.59% (🎯 68%) 1561 / 2344
🟢 Branches 80.91% (🎯 70%) 6263 / 7740
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/renderer/renderElement.ts 83.85% 76.15% 100% 83.85% 84-86, 108-109, 167-168, 172-173, 231-232, 280, 326-327, 340-357, 368-371, 385, 408-409, 411-412, 433, 594, 596-609, 670-672, 700-710, 751-759, 765-766, 770-833, 838-840, 893-895, 917, 920, 947-948
Generated in workflow #2409

@ad1992 ad1992 merged commit c1926f3 into master May 7, 2024
@ad1992 ad1992 deleted the aakansha/lint branch May 7, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ad1992