Skip to content

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Apr 17, 2024

fix #7897

The issue was while we're pre-filtering out the text element being editing, I was retrieving the current container's bound text from the scene elements map, not the filtered elements map, which resulted in always returning the text even if it was not meant to be rendered.

@vercel
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Apr 17, 2024 11:44am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Apr 17, 2024 11:44am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Apr 17, 2024 11:44am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 11:44am

@github-actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 64.37% (🎯 70%) 48530 / 75385
🔴 Statements 64.37% (🎯 70%) 48530 / 75385
🔴 Functions 65.04% (🎯 68%) 1461 / 2246
🟢 Branches 80.13% (🎯 70%) 5837 / 7284
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/renderer/staticScene.ts 68.68% 84.61% 100% 68.68% 103-104, 120-165, 178-179, 220-226, 228-231, 303-304, 311-371
Generated in workflow #2301

@dwelle dwelle merged commit 5211b00 into master Apr 17, 2024
@dwelle dwelle deleted the dwelle/fix-double-text branch April 17, 2024 11:48
dwelle added a commit to dwelle/excalidraw that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double text positioning error

2 participants