Skip to content

fix: collision regressions from vector geometry rewrite #7902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2024
Merged

fix: collision regressions from vector geometry rewrite #7902

merged 3 commits into from
Apr 17, 2024

Conversation

@ryan-di
Copy link
Member

@ryan-di ryan-di commented Apr 17, 2024

No description provided.

@vercel
Copy link

vercel bot commented Apr 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs 🔄 Building (Inspect) Visit Preview Apr 17, 2024 5:33am
excalidraw ✅ Ready (Inspect) Visit Preview Apr 17, 2024 5:33am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Apr 17, 2024 5:33am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Apr 17, 2024 5:33am

@github-actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 64.37% (🎯 70%) 48530 / 75385
🔴 Statements 64.37% (🎯 70%) 48530 / 75385
🔴 Functions 65.04% (🎯 68%) 1461 / 2246
🟢 Branches 80.13% (🎯 70%) 5837 / 7284
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/components/App.tsx 69.08% 75.7% 67.87% 69.08% 473-474, 580-589, 684-685, 703-704, 724-784, 787-793, 796-799, 802-878, 881-900, 903-908, 916-926, 928-929, 934-935, 939-941, 955, 962-1223, 1283-1284, 1295-1296, 1324-1326, 1336-1381, 1407, 1417, 1424-1427, 1436-1440, 1471-1472, 1556-1566, 1571-1586, 1590-1637, 1708-1713, 1742-1747, 1750-1780, 1788-1813, 1816-1825, 1828-1940, 1943-1951, 1960-1973, 1976-2002, 2005-2076, 2079-2119, 2165-2166, 2180-2181, 2218-2219, 2223-2224, 2240-2247, 2252-2265, 2271-2272, 2277-2285, 2287-2295, 2307, 2347-2348, 2370-2371, 2378, 2439-2441, 2444-2449, 2454-2455, 2492-2500, 2505-2514, 2552-2553, 2636-2637, 2641, 2644-2645, 2653-2656, 2665-2678, 2684-2687, 2690, 2692-2693, 2700-2701, 2707-2708, 2711-2712, 2720-2721, 2724-2725, 2728-2731, 2742-2750, 2755-2756, 2805-2806, 2820-2826, 2832-2840, 2844-2852, 2856-2857, 2860-2893, 2896-2908, 2919-2920, 2931-2932, 2949-2953, 2957-2960, 2967-2969, 2987-2994, 2997, 2999-3004, 3008-3010, 3031-3032, 3039-3041, 3043-3066, 3092, 3098, 3154-3155, 3172-3174, 3196-3197, 3203-3206, 3212-3293, 3365-3366, 3425, 3435-3453, 3456-3462, 3465-3466, 3472-3485, 3571-3572, 3574-3575, 3580-3582, 3590-3591, 3614-3628, 3633-3652, 3675-3676, 3748, 3757-3758, 3760-3767, 3782-3786, 3797-3798, 3801-3805, 3807-3808, 3810-3813, 3838-3839, 3848-3850, 3852, 3930-3933, 3955-3957, 3967-3968, 3970-3990, 3993-3999, 4016-4019, 4025-4028, 4038-4045, 4049-4050, 4056, 4084-4088, 4092, 4097-4098, 4103-4107, 4135-4136, 4139-4140, 4143-4144, 4152-4156, 4161-4162, 4168-4178, 4183-4210, 4215-4226, 4293, 4319-4320, 4385-4391, 4474, 4499, 4525-4527, 4594-4595, 4610-4611, 4781-4782, 4785-4786, 4794, 4842-4846, 4897-4904, 4910-4976, 5020, 5069, 5096, 5103-5104, 5113-5116, 5147, 5195-5198, 5201-5207, 5209-5212, 5227-5236, 5239-5240, 5322-5323, 5326, 5328-5333, 5339-5341, 5343, 5352, 5374-5379, 5381-5384, 5388-5389, 5399-5499, 5503-5504, 5519-5520, 5553-5554, 5581-5582, 5615-5641, 5648-5649, 5671-5672, 5691, 5693-5736, 5741-5742, 5744-5745, 5761-5762, 5768-5769, 5773-5776, 5779-5780, 5795-5822, 5830-5831, 5835-5838, 5840-5844, 5862-5866, 5912-5917, 5919-5921, 5937, 5939-5952, 5977-5980, 6024, 6041-6042, 6044-6067, 6082-6083, 6194-6222, 6291-6295, 6319-6320, 6340-6341, 6435, 6441-6442, 6465-6484, 6499, 6627, 6649-6687, 6691-6741, 6756, 6765, 6799-6805, 6820-6822, 6964-6967, 6991-7022, 7035, 7037-7045, 7059, 7061-7069, 7076-7079, 7087-7092, 7119-7120, 7125-7127, 7130-7131, 7156-7157, 7188-7189, 7272-7273, 7322-7335, 7396-7399, 7425-7426, 7462-7463, 7476, 7494-7500, 7507-7510, 7533-7539, 7611, 7617, 7632-7639, 7642-7649, 7705, 7782-7783, 7804-7806, 7809, 7823-7847, 7950-7974, 7984-8023, 8036-8037, 8046-8053, 8067-8080, 8093-8098, 8152-8178, 8180-8181, 8255-8256, 8263, 8265-8301, 8330, 8391, 8416-8418, 8443-8448, 8450-8451, 8456-8458, 8461-8481, 8495-8496, 8502-8511, 8516, 8520-8524, 8533-8537, 8540-8545, 8549-8556, 8586, 8588-8592, 8594-8604, 8620-8622, 8633-8641, 8645-8689, 8692-8763, 8771, 8789-8796, 8798-8814, 8829-8851, 8870-8872, 8917-8918, 8948-8949, 8968, 9045-9049, 9051-9067, 9069-9073, 9085-9086, 9096-9112, 9130-9149, 9151-9152, 9173-9174, 9178-9179, 9189, 9191-9194, 9196-9197, 9237, 9258-9259, 9285, 9288, 9329, 9343-9351, 9368-9369, 9401-9404, 9493-9500, 9526-9527, 9568-9622, 9670-9671, 9680-9683, 9688-9689, 9710-9712, 9714-9718, 9756
packages/utils/geometry/shape.ts 81.93% 88.88% 90% 81.93% 192-193, 259-262, 270-321
Generated in workflow #2300

@ryan-di ryan-di marked this pull request as ready for review April 17, 2024 05:33
dwelle
dwelle approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@dwelle dwelle merged commit bbcca06 into master Apr 17, 2024
@dwelle dwelle deleted the fix-geometry-regressions branch April 17, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryan-di @dwelle