Skip to content

fix: hit test for closed sharp curves #7881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: hit test for closed sharp curves #7881

merged 1 commit into from
Apr 12, 2024

Conversation

@ryan-di
Copy link
Member

@ryan-di ryan-di commented Apr 12, 2024

close #7879

@ryan-di ryan-di requested a review from dwelle April 12, 2024 09:43
@vercel
Copy link

vercel bot commented Apr 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Apr 12, 2024 9:43am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Apr 12, 2024 9:43am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Apr 12, 2024 9:43am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 12, 2024 9:43am

@github-actions
Copy link

github-actions bot commented Apr 12, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 64.38% (🎯 70%) 48428 / 75222
🔴 Statements 64.38% (🎯 70%) 48428 / 75222
🔴 Functions 65.01% (🎯 68%) 1459 / 2244
🟢 Branches 80.17% (🎯 70%) 5827 / 7268
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/components/App.tsx 69.08% 75.75% 67.87% 69.08% 473-474, 580-589, 684-685, 703-704, 724-784, 787-793, 796-799, 802-878, 881-900, 903-908, 916-926, 928-929, 934-935, 939-941, 955, 962-1221, 1281-1282, 1293-1294, 1322-1324, 1334-1379, 1405, 1415, 1422-1425, 1434-1438, 1469-1470, 1554-1564, 1569-1584, 1588-1635, 1706-1711, 1740-1745, 1748-1778, 1786-1811, 1814-1823, 1826-1938, 1941-1949, 1958-1971, 1974-2000, 2003-2074, 2077-2117, 2163-2164, 2178-2179, 2216-2217, 2221-2222, 2238-2245, 2250-2263, 2269-2270, 2275-2283, 2285-2293, 2305, 2345-2346, 2368-2369, 2376, 2437-2439, 2442-2447, 2452-2453, 2490-2498, 2503-2512, 2550-2551, 2634-2635, 2639, 2642-2643, 2651-2654, 2663-2676, 2682-2685, 2688, 2690-2691, 2698-2699, 2705-2706, 2709-2710, 2718-2719, 2722-2723, 2726-2729, 2740-2748, 2753-2754, 2803-2804, 2818-2824, 2830-2838, 2842-2850, 2854-2855, 2858-2891, 2894-2906, 2917-2918, 2929-2930, 2947-2951, 2955-2958, 2965-2967, 2985-2992, 2995, 2997-3002, 3006-3008, 3029-3030, 3037-3039, 3041-3064, 3090, 3096, 3152-3153, 3170-3172, 3194-3195, 3201-3204, 3210-3291, 3363-3364, 3423, 3433-3451, 3454-3460, 3463-3464, 3470-3483, 3569-3570, 3572-3573, 3578-3580, 3588-3589, 3612-3626, 3631-3650, 3673-3674, 3746, 3755-3756, 3758-3765, 3780-3784, 3795-3796, 3799-3803, 3805-3806, 3808-3811, 3836-3837, 3846-3848, 3850, 3928-3931, 3953-3955, 3965-3966, 3968-3988, 3991-3997, 4014-4017, 4023-4026, 4036-4043, 4047-4048, 4054, 4082-4086, 4090, 4095-4096, 4101-4105, 4133-4134, 4137-4138, 4141-4142, 4150-4154, 4159-4160, 4166-4176, 4181-4208, 4213-4224, 4291, 4317-4318, 4383-4389, 4489, 4515-4517, 4584-4585, 4600-4601, 4771-4772, 4775-4776, 4784, 4832-4836, 4887-4894, 4900-4966, 5010, 5059, 5086, 5093-5094, 5103-5106, 5137, 5185-5188, 5191-5197, 5199-5202, 5217-5226, 5229-5230, 5312-5313, 5316, 5318-5323, 5329-5331, 5333, 5342, 5364-5369, 5371-5374, 5378-5379, 5389-5489, 5493-5494, 5509-5510, 5543-5544, 5571-5572, 5605-5631, 5638-5639, 5661-5662, 5681, 5683-5726, 5731-5732, 5734-5735, 5751-5752, 5758-5759, 5763-5766, 5769-5770, 5785-5812, 5820-5821, 5825-5828, 5830-5834, 5852-5856, 5902-5907, 5909-5911, 5927, 5929-5942, 5967-5970, 6014, 6031-6032, 6034-6057, 6072-6073, 6184-6212, 6281-6285, 6309-6310, 6330-6331, 6425, 6431-6432, 6455-6474, 6489, 6617, 6639-6677, 6681-6731, 6746, 6755, 6789-6795, 6810-6812, 6954-6957, 6981-7012, 7025, 7027-7035, 7049, 7051-7059, 7066-7069, 7077-7082, 7109-7110, 7115-7117, 7120-7121, 7146-7147, 7178-7179, 7262-7263, 7312-7325, 7386-7389, 7415-7416, 7452-7453, 7466, 7484-7490, 7497-7500, 7523-7529, 7601, 7607, 7622-7629, 7632-7639, 7695, 7772-7773, 7794-7796, 7799, 7813-7837, 7940-7964, 7974-8013, 8026-8027, 8036-8043, 8057-8070, 8083-8088, 8142-8168, 8170-8171, 8245-8246, 8253, 8255-8291, 8320, 8381, 8406-8408, 8433-8438, 8440-8441, 8446-8448, 8451-8471, 8485-8486, 8492-8501, 8506, 8510-8514, 8523-8527, 8530-8535, 8539-8546, 8576, 8578-8582, 8584-8594, 8610-8612, 8623-8631, 8635-8679, 8682-8753, 8761, 8779-8786, 8788-8804, 8819-8841, 8860-8862, 8907-8908, 8938-8939, 8958, 9035-9039, 9041-9057, 9059-9063, 9075-9076, 9086-9102, 9120-9139, 9141-9142, 9163-9164, 9168-9169, 9179, 9181-9184, 9186-9187, 9227, 9248-9249, 9275, 9278, 9319, 9333-9341, 9358-9359, 9391-9394, 9483-9490, 9516-9517, 9558-9612, 9660-9661, 9670-9673, 9678-9679, 9700-9702, 9704-9708, 9746
packages/utils/geometry/shape.ts 79.86% 88.23% 88.88% 79.86% 159-160, 226-229, 237-288
Generated in workflow #2261

dwelle
dwelle approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dwelle dwelle merged commit 4689a6b into master Apr 12, 2024
@dwelle dwelle deleted the closed-curve-fix branch April 12, 2024 10:58
@dwelle dwelle mentioned this pull request Apr 13, 2024
Closed
@ryan-di ryan-di mentioned this pull request Jun 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

I can't select any elements on the canvas

3 participants

@ryan-di @dwelle