Skip to content

fix: include borders when testing insides of a shape #7865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: include borders when testing insides of a shape #7865

merged 1 commit into from
Apr 9, 2024

Conversation

@ryan-di
Copy link
Member

@ryan-di ryan-di commented Apr 8, 2024

No description provided.

@ryan-di ryan-di requested a review from dwelle April 8, 2024 08:22
@vercel
Copy link

vercel bot commented Apr 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Apr 8, 2024 8:25am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Apr 8, 2024 8:25am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Apr 8, 2024 8:25am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 8:25am

@github-actions
Copy link

github-actions bot commented Apr 8, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 64.33% (🎯 70%) 48207 / 74930
🔴 Statements 64.33% (🎯 70%) 48207 / 74930
🔴 Functions 65.12% (🎯 68%) 1455 / 2234
🟢 Branches 80.19% (🎯 70%) 5815 / 7251
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/element/collision.ts 100% 92.3% 100% 100%
Generated in workflow #2232

dwelle
dwelle approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dwelle dwelle merged commit 4987cc5 into master Apr 9, 2024
@dwelle dwelle deleted the geometry branch April 9, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryan-di @dwelle