fix: Two finger panning is slow #7849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
dwelle
reviewed
May 19, 2024
Comment on lines
+5100
to
+5101
| scrollX: zoomState.scrollX + 2 * (deltaX / nextZoom), | ||
| scrollY: zoomState.scrollY + 2 * (deltaY / nextZoom), |
There was a problem hiding this comment.
why 2x? Isn't this more related to devicePixelRatio which on most mobile touchscreens would coincide with 2?
|
All I can confirm is I deployed this change 6 weeks ago to Obsidian and since then I had received no complains. It works well for me on iPad and Android. Finally panning is as quick as with a mouse. |
|
Yeah, I was just wondering if there was a reasoning behind it, or it's just a magic number. I'll add a comment it's a magic number then. :) |
dwelle
reviewed
May 19, 2024
dwelle
approved these changes
May 19, 2024
|
Thanks Zsolt! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2497
fix #6913
With this change, two finger panning on iPad matches the single finger panning with the hand tool. I tested this with various zoom levels.
sorry - can't figure out how to update tests to accommodate the change :(