Skip to content

fix: excalidrawAPI.toggleSidebar not switching between tabs correctly #7821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix: excalidrawAPI.toggleSidebar not switching between tabs correctly #7821

merged 2 commits into from
Mar 28, 2024

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Mar 28, 2024

No description provided.

@vercel
Copy link

vercel bot commented Mar 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Mar 28, 2024 1:39pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Mar 28, 2024 1:39pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Mar 28, 2024 1:39pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 1:39pm

@github-actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 64.85% (🎯 70%) 46667 / 71956
🔴 Statements 64.85% (🎯 70%) 46667 / 71956
🔴 Functions 66.22% (🎯 68%) 1412 / 2132
🟢 Branches 79.96% (🎯 70%) 5683 / 7107
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/components/App.tsx 68.73% 75.16% 67.55% 68.73% 457-458, 564-573, 668-669, 687-688, 708-768, 771-777, 780-783, 786-862, 865-884, 887-892, 900-910, 912-913, 918-919, 923-925, 939, 946-1205, 1265-1266, 1277-1278, 1306-1308, 1318-1363, 1389, 1399, 1406-1409, 1418-1422, 1453-1454, 1538-1548, 1553-1568, 1572-1619, 1690-1695, 1724-1729, 1732-1762, 1770-1795, 1798-1807, 1810-1922, 1925-1933, 1942-1955, 1958-1984, 1987-2058, 2061-2101, 2147-2148, 2162-2163, 2200-2201, 2205-2206, 2222-2229, 2234-2247, 2253-2254, 2259-2267, 2269-2277, 2289, 2329-2330, 2352-2353, 2360, 2421-2423, 2426-2431, 2436-2437, 2474-2482, 2487-2496, 2534-2535, 2618-2619, 2623, 2626-2627, 2635-2638, 2647-2660, 2666-2669, 2672, 2674-2675, 2682-2683, 2689-2690, 2693-2694, 2702-2703, 2706-2707, 2710-2713, 2724-2732, 2737-2738, 2788-2789, 2803-2809, 2815-2823, 2827-2835, 2839-2840, 2843-2876, 2879-2891, 2902-2903, 2914-2915, 2932-2936, 2940-2943, 2950-2952, 2970-2977, 2980, 2982-2987, 2991-2993, 3014-3015, 3022-3024, 3026-3049, 3075, 3081, 3137-3138, 3155-3157, 3179-3180, 3186-3189, 3195-3276, 3348-3349, 3354-3357, 3420, 3430-3448, 3451-3457, 3460-3461, 3467-3480, 3566-3567, 3569-3570, 3575-3577, 3585-3586, 3609-3623, 3628-3647, 3670-3671, 3743, 3762-3766, 3777-3778, 3781-3785, 3787-3788, 3790-3793, 3818-3819, 3828-3830, 3832, 3910-3913, 3935-3937, 3947-3948, 3950-3970, 3973-3979, 3996-3999, 4005-4008, 4018-4025, 4029-4030, 4040, 4068-4072, 4076, 4081-4082, 4087-4091, 4123-4124, 4127-4128, 4136-4140, 4145-4146, 4152-4162, 4167-4194, 4199-4210, 4277, 4303-4304, 4396, 4587-4588, 4591-4592, 4600, 4609, 4611-4612, 4653-4657, 4714-4721, 4727-4793, 4837, 4886, 4913, 4920-4921, 4930-4933, 4964, 5012-5015, 5018-5024, 5026-5029, 5044-5053, 5056-5057, 5139-5140, 5143, 5145-5150, 5156-5158, 5160, 5169, 5191-5196, 5198-5201, 5205-5206, 5216-5316, 5320-5321, 5337-5338, 5394-5395, 5422-5423, 5456-5482, 5489-5490, 5512-5513, 5532, 5534-5577, 5582-5583, 5585-5586, 5602-5603, 5609-5610, 5614-5617, 5620-5621, 5636-5663, 5671-5672, 5676-5679, 5681-5685, 5703-5707, 5753-5758, 5760-5762, 5778, 5780-5793, 5818-5821, 5865, 5882-5883, 5885-5908, 5923-5924, 6035-6063, 6132-6136, 6161-6162, 6182-6183, 6277, 6283-6284, 6307-6326, 6341, 6475, 6498-6539, 6543-6596, 6611, 6620, 6654-6660, 6675-6677, 6820-6823, 6847-6881, 6894, 6896-6904, 6918, 6920-6928, 6935-6938, 6946-6951, 6978-6979, 6984-6986, 6989-6990, 7015-7016, 7047-7048, 7131-7132, 7181-7194, 7255-7258, 7284-7285, 7316-7317, 7330, 7348-7354, 7361-7364, 7387-7393, 7465, 7471, 7486-7493, 7496-7503, 7560, 7639-7640, 7661-7663, 7666, 7680-7704, 7808-7832, 7842-7881, 7894-7895, 7904-7911, 7925-7938, 7951-7956, 8010-8036, 8038-8039, 8113-8114, 8121, 8123-8159, 8188, 8239, 8265-8267, 8292-8297, 8299-8300, 8305-8307, 8310-8330, 8344-8345, 8351-8360, 8365, 8369-8373, 8382-8386, 8389-8394, 8398-8405, 8435, 8437-8441, 8443-8453, 8469-8471, 8482-8490, 8494-8538, 8541-8612, 8620, 8638-8645, 8647-8663, 8678-8700, 8719-8721, 8767-8768, 8799-8800, 8820, 8897-8901, 8903-8919, 8921-8925, 8937-8938, 8948-8964, 8982-9001, 9003-9004, 9025-9026, 9030-9031, 9041, 9043-9046, 9048-9049, 9089, 9110-9111, 9137, 9140, 9181, 9195-9203, 9220-9221, 9253-9256, 9345-9352, 9378-9379, 9420-9474, 9522-9523, 9532-9535, 9540-9541, 9562-9564, 9566-9570, 9608
packages/excalidraw/components/Sidebar/SidebarTab.tsx 100% 100% 100% 100%
Generated in workflow #2149

@dwelle dwelle merged commit 65bc500 into master Mar 28, 2024
@dwelle dwelle deleted the dwelle/fix-toggleSidebar branch March 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dwelle