Skip to content

fix: add missing font metrics for Assistant #7752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2024
Merged

fix: add missing font metrics for Assistant #7752

merged 2 commits into from
Mar 6, 2024

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Mar 6, 2024 •
edited
Loading

fix #7751

@vercel
Copy link

vercel bot commented Mar 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Mar 6, 2024 9:51am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Mar 6, 2024 9:51am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Mar 6, 2024 9:51am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 9:51am

@github-actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 64.9% (🎯 70%) 46165 / 71130
🔴 Statements 64.9% (🎯 70%) 46165 / 71130
🔴 Functions 66.16% (🎯 68%) 1398 / 2113
🟢 Branches 80.07% (🎯 70%) 5649 / 7055
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/element/textElement.ts 94.73% 94.66% 95% 94.73% 179-180, 220, 363-364, 576-583, 595-616, 630-631, 646-647, 686-693, 791-792, 807-808
Generated in workflow #2038

@dwelle dwelle merged commit 68b1fdb into master Mar 6, 2024
@dwelle dwelle deleted the dwelle/fix-missing-assistant-metrics branch March 6, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some elements don't appear in export

2 participants

@dwelle