-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
refactor: update collision from ga to vector geometry #7636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
# Conflicts: # packages/excalidraw/components/App.tsx # packages/excalidraw/element/textElement.ts # packages/excalidraw/renderer/interactiveScene.ts
dwelle
approved these changes
Apr 3, 2024
|
Thanks for the PR @ryan-di! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve upon the collision methods that we have for a given element in the editor and it is in relation to the following goals:
Under
utils/geometry, two filesgeometry.tsandshape.tsare introduced.shape.tsdefines various pure geometric shapes, like polygon, curves, and ellipses. It also includes methods to convert an element or a Drawable into pure geometric shapes. Then ingeometry.ts, pure methods for working with different pure geometric shapes are provided.And
excalidraw/element/collision.tshas been updated so that the simple apis uses the pure functions fromutils/collision.ts, which depends ongeometry.tsandshape.ts.In
App.tsx, we have public and private methods that depend on app state and cache to get pure geometric shapes and to carry out collision detection for different use cases.