Skip to content

build: Welcome ESM and Bye Bye UMD #7441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Jan 1, 2024
Merged

build: Welcome ESM and Bye Bye UMD #7441

merged 46 commits into from
Jan 1, 2024

Conversation

@ad1992
Copy link
Member

@ad1992 ad1992 commented Dec 14, 2023 •
edited
Loading

Some rough notes - https://keybu.com/l/767f0bbc21a222fbda38/esm-bundle-for-excalidraw

  • Ship unbundled and unmodified ESM so it can be further processed by downstream - try here
  • Ship bundled esm with dependencies so it can be directly used in browser via script tag - Try here
  • Fix environment variables since import.meta isn't supported
  • Fix "index.js:735 Failed to load language en: globImport_locales_json is not defined" error
  • Fix webpack chunk name import errors
  • Remove entry.js and all unnecessary files
  • Remove Preact build and env vars
  • Remove webpack completely as its not needed anymore
  • Check typings should be working well
  • Preact should work without any additional support
    Make Library Tree-Shakeable will be coming back to this in separate PR
    Bundle CSS with JS for bundled ESM - not doing this since its better to load CSS via link tag as it gets loaded in parallel instead of blocking JS

@vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jan 1, 2024 2:45pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jan 1, 2024 2:45pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 1, 2024 2:45pm

@github-actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 65.03% / 70% 44846 / 68959
🔴 Statements 65.03% / 70% 44846 / 68959
🔴 Functions 66.02% / 68% 1366 / 2069
🟢 Branches 79.89% / 70% 5536 / 6929
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/i18n.ts 88.23% 72% 11.66% 88.23% 96, 101-103, 120-121, 131-135, 141, 143-150
packages/excalidraw/index.tsx 79% 88.88% 75% 79% 85-89, 144-193
packages/excalidraw/main.js 0% 0% 0% 0% 1-5
packages/excalidraw/components/App.tsx 68.67% 75.07% 68.5% 68.67% 445-446, 624-625, 643-644, 664-724, 727-733, 736-739, 742-818, 821-840, 848-859, 861-862, 867-868, 872-874, 893-1138, 1198-1199, 1210-1211, 1238-1243, 1253-1297, 1323, 1333, 1340-1343, 1378-1379, 1459-1465, 1470-1484, 1488-1534, 1602-1607, 1636-1641, 1644-1674, 1682-1707, 1710-1719, 1722-1835, 1838-1846, 1855-1868, 1871-1897, 1900-1971, 1974-2014, 2060-2061, 2079-2080, 2117-2118, 2122-2123, 2139-2146, 2151-2164, 2170-2171, 2176-2184, 2186-2194, 2206, 2246-2247, 2269-2270, 2277, 2338-2340, 2343-2348, 2353-2354, 2389-2397, 2402-2411, 2449-2450, 2533-2534, 2538, 2541-2542, 2550-2553, 2562-2575, 2581-2584, 2587, 2589-2590, 2597-2598, 2604-2605, 2613-2614, 2617-2618, 2621-2624, 2627-2630, 2641-2649, 2654-2655, 2711-2712, 2726-2732, 2738-2746, 2750-2758, 2762-2763, 2766-2799, 2802-2814, 2825-2826, 2837-2838, 2855-2859, 2863-2866, 2873-2875, 2893-2900, 2903, 2905-2910, 2914-2916, 2932-2933, 2935-2944, 2970, 2976, 3015-3016, 3033-3035, 3057-3058, 3064-3067, 3073-3148, 3220-3221, 3226-3229, 3292, 3302-3320, 3323-3329, 3332-3333, 3339-3352, 3438-3439, 3441-3442, 3447-3449, 3457-3458, 3481-3495, 3500-3519, 3542-3543, 3576-3578, 3603, 3622-3626, 3637-3638, 3641-3645, 3647-3648, 3650-3653, 3678-3679, 3688-3690, 3692, 3767-3770, 3792-3794, 3804-3805, 3807-3827, 3830-3836, 3853-3856, 3862-3865, 3875-3882, 3886-3887, 3892, 3920-3924, 3928, 3933-3934, 3939-3943, 3975-3976, 3979-3980, 3988-3992, 3996-4006, 4011-4038, 4043-4054, 4113, 4139-4140, 4231, 4408-4409, 4412-4413, 4421, 4433, 4435-4436, 4477-4481, 4532-4538, 4544-4607, 4650, 4699, 4725, 4732-4733, 4742-4745, 4775, 4823-4826, 4829-4835, 4837-4840, 4855-4864, 4867-4868, 4949-4950, 4953, 4955-4956, 4962-4964, 4966, 4975, 4997-5002, 5004-5007, 5011-5012, 5022-5109, 5112-5113, 5127-5128, 5179-5180, 5207-5208, 5241-5267, 5274-5275, 5297-5298, 5317, 5319-5362, 5367-5368, 5370-5371, 5387-5388, 5394-5395, 5399-5402, 5405-5406, 5421-5448, 5456-5457, 5461-5464, 5466-5470, 5531-5536, 5538-5540, 5556, 5558-5569, 5594-5597, 5655-5656, 5658-5681, 5696-5697, 5809-5837, 5902-5906, 5929-5930, 5950-5951, 6045, 6051-6052, 6075-6094, 6109, 6242, 6264-6305, 6309-6360, 6375, 6384, 6418-6424, 6439-6441, 6583-6587, 6611-6645, 6658, 6660-6667, 6681, 6683-6690, 6697-6700, 6708-6713, 6736-6737, 6740-6741, 6746-6748, 6751-6752, 6777-6778, 6806-6807, 6889-6890, 6939-6952, 7012-7015, 7041-7042, 7073-7074, 7087, 7105-7111, 7118-7121, 7144-7149, 7220-7223, 7229, 7244-7251, 7254-7261, 7318, 7392-7393, 7413-7415, 7418, 7432-7456, 7562-7581, 7591-7630, 7643-7644, 7653-7660, 7674-7686, 7699-7704, 7760-7788, 7790-7791, 7865-7869, 7876, 7878-7914, 7943, 7993, 8012-8014, 8039-8044, 8046-8047, 8052-8083, 8086-8110, 8124-8125, 8131-8140, 8145, 8149-8153, 8162-8166, 8169-8174, 8178-8185, 8215, 8217-8221, 8223-8233, 8249-8251, 8262-8270, 8274-8310, 8313-8384, 8392, 8410-8417, 8419-8435, 8450-8472, 8491-8493, 8538-8539, 8569-8570, 8586, 8663-8666, 8668-8684, 8686-8690, 8702-8703, 8713-8729, 8763-8764, 8768-8780, 8790, 8792-8795, 8797-8798, 8838, 8859-8860, 8886, 8889, 8929, 8943-8950, 8967-8968, 9000-9003, 9092-9099, 9125-9126, 9167-9221, 9265-9266, 9275-9278, 9283-9284, 9305-9307, 9309-9313, 9351
packages/excalidraw/components/TTDDialog/TTDDialog.tsx 40.2% 75% 30% 40.2% 101-108, 114-202, 242-265, 274-387
packages/excalidraw/data/blob.ts 58.54% 62.31% 67.85% 58.54% 24-32, 35, 55-63, 74-78, 80, 84, 92-97, 100-103, 106-108, 131-138, 151, 166-172, 190-191, 201-202, 220-221, 224-230, 234-235, 242-253, 268-278, 281-327, 330-333, 336-358, 373-383, 411, 413-414, 440-451, 458-459, 467-468, 474-475
packages/excalidraw/data/index.ts 40.1% 71.42% 50% 40.1% 56, 58-63, 83-187
packages/excalidraw/example/App.tsx 0% 0% 0% 0% 1-924
packages/excalidraw/example/CustomFooter.tsx 0% 0% 0% 0% 1-73
packages/excalidraw/example/MobileFooter.tsx 0% 0% 0% 0% 1-20
packages/excalidraw/example/index.tsx 0% 0% 0% 0% 1-17
packages/excalidraw/example/initialData.tsx 0% 0% 0% 0% 1-994
packages/excalidraw/example/sidebar/ExampleSidebar.tsx 0% 0% 0% 0% 1-32
packages/excalidraw/scene/export.ts 87.36% 80.39% 80% 87.36% 70-95, 115-116, 125, 181-182, 206-210, 339-340, 362-372, 458-467
scripts/autorelease.js 0% 0% 0% 0% 1-70
scripts/buildExample.mjs 0% 0% 0% 0% 1-35
scripts/buildPackage.js 0% 0% 0% 0% 1-135
Generated in workflow #1518

@ad1992
Copy link
Member Author

ad1992 commented Dec 15, 2023

@excalibot trigger release

@excalibot
Copy link
Member

excalibot commented Dec 15, 2023

@ad1992

@ad1992
Copy link
Member Author

ad1992 commented Dec 15, 2023

@excalibot trigger release

@excalibot
Copy link
Member

excalibot commented Dec 15, 2023

@ad1992 Skipping release as no valid diff found

@ad1992
Copy link
Member Author

ad1992 commented Dec 15, 2023

@excalibot trigger release

@excalibot
Copy link
Member

excalibot commented Dec 15, 2023

@ad1992 package couldn't be published ⚠️!

@excalidraw excalidraw deleted a comment from excalibot Dec 15, 2023
@excalibot
Copy link
Member

excalibot commented Dec 29, 2023

@ad1992 Preview version has been shipped 🚀
You can use @excalidraw/excalidraw@0.17.1-7441-ab3816d for testing!

@ad1992
Copy link
Member Author

ad1992 commented Dec 29, 2023

@excalibot trigger release

@excalibot
Copy link
Member

excalibot commented Dec 29, 2023

@ad1992 Preview version has been shipped 🚀
You can use @excalidraw/excalidraw@0.17.1-7441-8b04eb5 for testing!

@ad1992 ad1992 marked this pull request as ready for review December 29, 2023 08:53
ad1992
ad1992 commented Jan 1, 2024
View reviewed changes
@ad1992 ad1992 requested a review from dwelle January 1, 2024 06:26
@ad1992
Copy link
Member Author

ad1992 commented Jan 1, 2024

@excalibot trigger release

@excalibot
Copy link
Member

excalibot commented Jan 1, 2024

@ad1992 Preview version has been shipped 🚀
You can use @excalidraw/excalidraw@0.17.1-7441-4e2c539 for testing!

ad1992
ad1992 commented Jan 1, 2024
View reviewed changes
@ad1992 ad1992 merged commit a8064ba into master Jan 1, 2024
@ad1992 ad1992 deleted the aakansha/esm branch January 1, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle dwelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ad1992 @excalibot @dwelle