Skip to content

fix: several eyeDropper fixes #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 17, 2023
Merged

fix: several eyeDropper fixes #7002

merged 4 commits into from
Sep 17, 2023

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Sep 17, 2023 •
edited
Loading

Tried to write a test for it, but we'd have to mock too many things including getImageData.

  • fix eyeDropper not working due to its backdrop having lower z-index than interactive canvas fd7382d
  • potential fix for mobile (right now, tablets) so we always pick current color on click instead of relying on pointermove 22cca0a
  • fix eyedropper preview picking incorrect color on alt when picking from color-picker (as opposed to I/Shift-S/Shift-G) ffdff28

@vercel
Copy link

vercel bot commented Sep 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Sep 17, 2023 11:11am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Sep 17, 2023 11:11am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2023 11:11am

@github-actions
Copy link

github-actions bot commented Sep 17, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/excalidraw.production.min.js 295.29 KB (+0.05% 🔺) 6 s (+0.05% 🔺) 502 ms (-34.39% 🔽) 6.5 s
dist/excalidraw-assets/locales 261.47 KB (0%) 5.3 s (0%) 242 ms (-8.97% 🔽) 5.5 s
dist/excalidraw-assets/vendor*.js 28.06 KB (0%) 562 ms (0%) 134 ms (+4.46% 🔺) 695 ms

@github-actions
Copy link

github-actions bot commented Sep 17, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 74.58% / 70% 42082 / 56420
🟢 Statements 74.58% / 70% 42082 / 56420
🟢 Functions 70.1% / 68% 1346 / 1920
🟢 Branches 80.82% / 70% 5188 / 6419
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/types.ts 100% 100% 100% 100%
src/components/EyeDropper.tsx 14.47% 100% 0% 14.47% 33-221
src/components/ColorPicker/ColorInput.tsx 77.44% 62.5% 16.66% 77.44% 39-46, 55-56, 80-81, 84-85, 89-95, 113-121
src/components/ColorPicker/ColorPicker.tsx 78.87% 68.18% 42.85% 78.87% 25-28, 31-43, 87, 99-100, 108-111, 120-122, 124-130, 171-190, 192-199, 207-208
Generated in workflow #353

@dwelle dwelle changed the title fix: incorrect eyedropper backdrop z-index after canvas split fix: several eyeDropper fixes Sep 17, 2023
@dwelle dwelle merged commit c1952fd into master Sep 17, 2023
@dwelle dwelle deleted the dwelle/fix-eyedropper branch September 17, 2023 11:24
This was referenced Nov 15, 2023
Closed
Closed
alswl pushed a commit to alswl/excalidraw that referenced this pull request Nov 15, 2023
@dwelle @alswl
fix: several eyeDropper fixes (excalidraw#7002)
7eb527f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dwelle