fix: preserve stylesPanelMode during canvas reset to prevent mobile color picker UI corruption #10253
+30
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Hell1213 is attempting to deploy a commit to the Excalidraw Team on Vercel. A member of the Team first needs to authorize it. |
|
based on my testing, the solution does work. |
…olor picker UI corruption - Preserve stylesPanelMode in actionClearCanvas to maintain mobile UI state - Add ResizeObserver to MobileShapeActions for proper width measurement - Fixes issue where color picker would show broken layout after canvas reset on mobile - Ensures mobile color picker always displays full interface with proper styling Fixes excalidraw#10252
Hell1213
force-pushed
the
fix/mobile-color-picker-reset-issue
branch
from
9621a22 to
fb859e6
Compare
|
hey @zsviczian Thanks for pointing that out! I’ve removed the excalidraw.code-workspace file and updated the PR. |
Hell1213
changed the title
Hell1213
changed the title
|
@dwelle pr is ready to review |
|
@Hell1213 Thanks for working on this! We've moved away from /cc @zsviczian @dwelle |
zsviczian
added a commit
to zsviczian/excalidraw
that referenced
this pull request
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10252 - Color picker falls apart after resetting the canvas on the new mobile UI
This PR addresses a critical mobile UI bug where the color picker would display incorrectly after canvas reset, showing only basic color swatches instead of the full expanded interface.
Root Cause
The issue was caused by two problems:
actionClearCanvas), thestylesPanelModewas being reset to"full"instead of preserving the current mode ("mobile"for mobile devices)MobileShapeActionscomponent was using synchronous width measurement that could fail during re-renders after canvas resetSolution
1. Preserve stylesPanelMode during canvas reset
actionClearCanvasto preserve the currentstylesPanelModevaluestylesPanelMode: "mobile"which is required for proper color picker display2. Improve width measurement reliability
useEffectwithResizeObserverfor accurate width measurementResizeObserveris not availableBefore/After Screenshots
Before (Broken)
The color picker shows only basic horizontal color swatches with "Stroke" text - broken layout after canvas reset.
After (Fixed)
The color picker displays the full expanded interface with proper sections: Background, Colors, Shades, Hex code - working correctly after canvas reset.
=>
Screencast.from.2025-10-26.14-29-36.mp4
Testing
Technical Details
The fix ensures that:
stylesPanelModestatecompactModepropsCloses #10252