feat: Add hex color validation with error feedback in ColorPicker #10234
+230
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add isValidHexColor() and getHexColorValidationError() functions - Display real-time validation errors for invalid hex codes - Show specific error messages for invalid length and characters - Add visual styling with red borders for error states - Include comprehensive tests for validation functions - Improve UX by providing immediate feedback instead of silent failures Fixes excalidraw#9527
|
@Hell1213 is attempting to deploy a commit to the Excalidraw Team on Vercel. A member of the Team first needs to authorize it. |
|
hey @dwelle I have created this pr for issue hex color validation now it has been resolved just waiting for your review . |
|
hey @excalibot , @dwelle this PR fixes #9527 (hex color validation). Ready for review whenever you have time |
|
hey @ryan-di , @zsviczian PR fixes #9527(hex color validation) is ready for review ?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements hex color validation with real-time error feedback in the ColorPicker component, addressing issue #9527.
Changes Made
Error Messages
Testing
Screenshots/Demo
When typing invalid hex codes like 'black2d' or '123456789', users now see:
Fixes #9527
Checklist