Skip to content

feat: Simplify the freedraw element at creation or restoration #10229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: Simplify the freedraw element at creation or restoration #10229

wants to merge 1 commit into from
+118 −14

Conversation

@mtolmacs
Copy link
Collaborator

@mtolmacs mtolmacs commented Oct 22, 2025

Simplify the curve points right at the creation point, so we don't store excessive and noisy detail in the element when exported.

@vercel
Copy link

vercel bot commented Oct 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
excalidraw Ready Ready Preview Oct 22, 2025 4:22pm
excalidraw-package-example Ready Ready Preview Oct 22, 2025 4:22pm
excalidraw-package-example-with-nextjs Ready Ready Preview Oct 22, 2025 4:22pm
1 Skipped Deployment
Project Deployment Preview Updated (UTC)
docs Ignored Ignored Oct 22, 2025 4:22pm

@mtolmacs mtolmacs requested a review from dwelle October 22, 2025 16:21
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 67.05% (🎯 60%) 75913 / 113213
🟢 Statements 67.05% (🎯 60%) 75913 / 113213
🟢 Functions 63.65% (🎯 63%) 2065 / 3244
🟢 Branches 80.18% (🎯 70%) 9300 / 11598
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/element/src/renderElement.ts 79.82% 75.44% 95% 79.82% 105-107, 209-210, 214-215, 241-242, 277-278, 370, 379, 401, 447-448, 462-471, 474, 503-506, 520, 543-544, 546-547, 565-567, 572, 604-605, 683, 685-698, 740-741, 767-769, 797-807, 816-817, 852-860, 866-867, 871-934, 959-960, 990-1012, 1028-1030, 1054-1106, 1114, 1141-1142
packages/element/src/utils.ts 95.64% 90.76% 100% 95.64% 83-89, 125-126, 143-144, 168-169, 406-411, 479-481
packages/excalidraw/components/App.tsx 73.7% 75.44% 72.72% 73.7% 522-523, 616-617, 735-736, 755-756, 782-842, 864-867, 870-946, 949-968, 996-997, 1050-1051, 1056-1189, 1196, 1199, 1212, 1220, 1252, 1257-1259, 1269, 1275, 1354-1358, 1362-1366, 1398-1399, 1416-1461, 1487, 1500, 1507-1510, 1519-1523, 1552-1558, 1575, 1653-1663, 1668-1683, 1687-1734, 1835-1840, 1850, 1874-1875, 1882-1887, 1890-1920, 1928-1957, 1970-2061, 2064-2072, 2075-2134, 2137-2178, 2181-2191, 2222-2223, 2246-2247, 2279-2280, 2284-2285, 2305-2313, 2318-2331, 2337-2338, 2342, 2353, 2357-2365, 2395, 2430-2431, 2451-2452, 2474-2475, 2482, 2497, 2527-2529, 2580-2583, 2598-2600, 2603-2608, 2613-2614, 2655-2663, 2668-2677, 2721-2723, 2825-2826, 2830, 2833-2834, 2842-2845, 2854-2867, 2873-2876, 2879, 2881-2882, 2889-2890, 2896-2897, 2900-2901, 2912, 2914-2918, 2921-2922, 2925-2926, 2937-2945, 2950-2951, 2980-2981, 2995-3001, 3007-3015, 3019-3027, 3031-3033, 3036-3090, 3093-3105, 3123-3125, 3129-3135, 3139-3146, 3154-3157, 3164-3165, 3173-3175, 3229, 3243, 3276-3277, 3288-3289, 3301-3308, 3340, 3346, 3373-3375, 3410-3413, 3416-3417, 3433-3435, 3457-3458, 3464-3468, 3474-3522, 3576, 3580, 3615-3616, 3673, 3683-3701, 3704-3710, 3713-3714, 3720-3736, 3776-3801, 3884-3885, 3908-3922, 3930-3936, 3950-3951, 3957-3970, 4028-4029, 4034-4052, 4055-4063, 4133-4143, 4179, 4213-4216, 4218-4240, 4362-4363, 4365-4372, 4406-4410, 4412-4413, 4415-4418, 4439-4440, 4447-4448, 4470-4480, 4490-4492, 4494, 4578-4581, 4603-4611, 4615-4617, 4627-4628, 4630-4650, 4657-4680, 4683-4689, 4706-4709, 4723, 4727-4734, 4738-4739, 4828-4832, 4836, 4844-4845, 4869, 4898-4899, 4902-4903, 4915-4919, 4924-4925, 4931-4941, 4946-4973, 4978-4989, 5092-5093, 5183, 5211, 5237-5239, 5316-5317, 5390-5391, 5526-5527, 5530-5531, 5547-5548, 5596, 5621-5622, 5664-5668, 5731-5738, 5740-5741, 5746-5812, 5857, 5914, 5941, 5948-5949, 5962-5965, 5982, 5988-5996, 5999-6000, 6002-6005, 6007-6008, 6059-6062, 6065-6069, 6071-6078, 6095-6104, 6107-6108, 6245-6246, 6249, 6251-6256, 6262-6264, 6266, 6275, 6277-6278, 6293-6298, 6300-6304, 6312, 6317-6318, 6335-6351, 6353, 6355-6358, 6362-6373, 6377-6378, 6393-6394, 6430, 6434, 6441-6453, 6480-6481, 6498-6510, 6513-6514, 6542, 6544-6574, 6581-6582, 6604-6605, 6624, 6626-6669, 6674-6675, 6677-6678, 6694-6695, 6701-6702, 6706-6710, 6713-6714, 6717-6827, 6846-6847, 6851-6854, 6856-6860, 6879-6883, 6930-6935, 6937-6939, 6958, 6960-6973, 6998-7001, 7056, 7073-7074, 7076-7099, 7114-7115, 7231-7259, 7325-7326, 7361-7365, 7384-7385, 7441-7442, 7461-7462, 7497-7510, 7569, 7575-7576, 7599-7618, 7627-7636, 7650, 7804-7842, 7858, 7865-7866, 7869-7873, 7911, 7920, 7956-7962, 7989-7991, 8073, 8121-8125, 8163-8166, 8188-8218, 8231, 8233-8241, 8255, 8257-8265, 8272-8275, 8283-8288, 8297-8298, 8302-8305, 8322-8339, 8382-8383, 8386-8388, 8391-8392, 8424-8425, 8451-8452, 8504-8505, 8518-8519, 8543-8545, 8547-8548, 8554-8556, 8558-8559, 8583-8596, 8600-8686, 8760-8761, 8813-8815, 8883-8896, 8899-8912, 8930, 8956-8962, 8973-8983, 9015-9021, 9054, 9096-9099, 9105, 9120-9130, 9133-9143, 9251, 9264, 9349-9351, 9354, 9390-9407, 9456-9459, 9509-9523, 9553-9577, 9611-9618, 9638-9639, 9674-9681, 9738-9743, 9752-9776, 9778-9779, 9859-9863, 9870, 9872-9908, 9937-9940, 10003, 10042-10044, 10050-10051, 10077-10082, 10084-10085, 10090-10092, 10095-10115, 10124-10125, 10131-10140, 10145, 10149-10153, 10162-10166, 10169-10174, 10206-10207, 10232-10234, 10279-10295, 10339-10353, 10370-10386, 10498-10502, 10571-10575, 10625-10626, 10646, 10677-10696, 10698-10699, 10731-10732, 10736-10737, 10747, 10749-10752, 10754-10755, 10795-10798, 10840-10841, 10851, 10893, 10912-10920, 10931-10936, 10946-10947, 10949-11017, 11040-11041, 11073-11076, 11170-11177, 11203-11204, 11215, 11261-11332, 11380-11381, 11390-11393, 11398-11399, 11420-11422, 11424-11428, 11466
packages/excalidraw/data/restore.ts 86.47% 80.76% 78.57% 86.47% 125-128, 153, 218, 285-287, 369, 373-375, 400, 489, 523-533, 598-599, 608-616, 624-625, 631-632, 636-639, 648, 650-664, 671-674, 676-704, 711-720, 729-738, 756-761
packages/excalidraw/eraser/index.ts 22.51% 100% 33.33% 22.51% 52-64, 73-76, 79-84, 87-188, 191-195, 199-302
packages/math/src/curve.ts 86.09% 82.71% 89.47% 86.09% 100-101, 238-239, 258-259, 268-278, 305-306, 329-330, 446-447, 449-450, 485-486, 489-490, 534-535, 541-542, 546-554, 557-597
Generated in workflow #6095 for commit aa3e134 by the Vitest Coverage Report Action

@mtolmacs mtolmacs marked this pull request as draft October 31, 2025 17:02
@mtolmacs
Copy link
Collaborator Author

mtolmacs commented Oct 31, 2025

Might need to rewrite freedraw point creation anyway, so holding back on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwelle dwelle Awaiting requested review from dwelle

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtolmacs