Improve MongoDB read model repopulation performance via BulkWriteAsync#1137
Open
Fariarx wants to merge 1 commit intoeventflow:develop-v1from
Open
Improve MongoDB read model repopulation performance via BulkWriteAsync#1137Fariarx wants to merge 1 commit intoeventflow:develop-v1from
Fariarx wants to merge 1 commit intoeventflow:develop-v1from
Conversation
|
Fariarx seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Member
|
Remove the need for approvals on builds as legacy v0 builds have been stopped (was using Windows Server). |
rasmus
reviewed
Dec 6, 2025
|
|
||
| var collection = _mongoDatabase.GetCollection<TReadModel>(readModelDescription.RootCollectionName.Value); | ||
| var filter = Builders<TReadModel>.Filter.In(readModel => readModel.Id, modelIds); | ||
| var results = await collection.Find(filter).ToListAsync(cancellationToken: cancellationToken); |
Member
There was a problem hiding this comment.
Suggested change
| var results = await collection.Find(filter).ToListAsync(cancellationToken: cancellationToken); | |
| var results = await collection.Find(filter).ToListAsync(cancellationToken: cancellationToken).ConfigureAwait(false); |
rasmus
reviewed
Dec 6, 2025
|
|
||
| if (readModelContext.IsMarkedForDeletion) | ||
| { | ||
| await DeleteAsync(readModelUpdate.ReadModelId, c); |
Member
There was a problem hiding this comment.
Suggested change
| await DeleteAsync(readModelUpdate.ReadModelId, c); | |
| await DeleteAsync(readModelUpdate.ReadModelId, c).ConfigureAwait(false); |
rasmus
reviewed
Dec 6, 2025
| x.ReadModelEnvelope.ReadModel) { IsUpsert = true }; | ||
|
|
||
| return replaceOneModel; | ||
| }), cancellationToken: c); |
Member
There was a problem hiding this comment.
Suggested change
| }), cancellationToken: c); | |
| }), cancellationToken: c).ConfigureAwait(false); |
Member
|
.review |
|
Findings
Next steps
Your friendly neighborhood AI |
Member
|
@Fariarx let me know if the AI review has value and it seems there's a misalignment of your commit email and your GitHub user. Align those and submit the CLA ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Impact:
Significantly accelerates read model repopulation in MongoDB.
Production proven:
This change has been running in production for over a year with excellent stability and 2-4x performance improvement for batches >1000 events during repopulation.