Fix lowering standard decorators on a class with inheritance causing field initializers before super call with useDefineForClassFields: false#4092
Open
furkanevran wants to merge 1 commit intoevanw:mainfrom
Conversation
…field initializers before super call Allow omitting the field initializer if it doesn't have a decorator since we don't initialize it with extra initializers and only set it to it's default value
furkanevran
changed the title
Author
|
I could also alternatively replace the condition on: esbuild/internal/js_parser/js_parser_lower_class.go Lines 608 to 610 in e9174d6 to class.ShouldLowerStandardDecorators || (result.lowerAllInstanceFields && class.ExtendsOrNil.Data != nil) |
volkanceylan
added a commit
to serenity-is/Serenity
that referenced
this pull request
Mar 29, 2025
…tialized class fields (evanw/esbuild#4092) either all fields should use "declare" modifier, or experimentalDecorators in tsconfig.json should be true again.
volkanceylan
added a commit
to serenity-is/Serenity
that referenced
this pull request
Mar 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow omitting the field initializers if the class have a decorator and the field doesn't since esbuild doesn't initialize it with extra initializers and only set it to it's default value when useDefineForClassFields is false
Fixes #4087