Provide a flag to auto-prefix local css classes when minified#3914
Open
chowey wants to merge 2 commits intoevanw:mainfrom
Open
Provide a flag to auto-prefix local css classes when minified#3914chowey wants to merge 2 commits intoevanw:mainfrom
chowey wants to merge 2 commits intoevanw:mainfrom
Conversation
chowey
force-pushed
the
local-css-prefix
branch
from
19fcc80 to
7c1e87c
Compare
|
@chowey Any reason to limit this to minified classnames? Local classname collission is still an issue without minification if you use common names such as |
Author
|
@ziemkowski If I understand you correctly, your requirement should already work. So long as your CSS files are correctly identified as CSS modules, local classnames (when minification is disabled) should not be an issue. esbuild already renames them. See this example. Taking these two files: .btn {
color: red;
}.btn {
color: blue;
}they successfully bundle into this one file: /* a.module.css */
.a_btn {
color: red;
}
/* b.module.css */
.b_btn {
color: blue;
} |
Author
|
@evanw is there anything needed to make this acceptable? Such as docs? Or is it a no-go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #3484 by providing an option to prefix css classes when minifying css modules.
I created the
--local-css-prefixcommand line flag, e.g.--local-css-prefix=myapp-. I also exported this through the Javascript API.You can now do e.g.
With the following input files:
index.js
classes.module.css
This produces the following output files:
dist/index.css
dist/index.js